-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump TextMateSharp version #443
Conversation
I noticed while working on this change that if I included the package reference for the updated TextMatesSharp: <PackageReference Include="TextMateSharp.Grammars" Version="1.0.59" /> in my project's csproj that syntax highlighting silently broke. Maybe someone has thoughts on why/how that might happen? |
Do you mean the IDE's syntax highlighting? |
No, the TextEditor widget's syntax highlighting stopped working. |
I should add that I tested this before PR'ing the Grammars change by branching master of this repo and bumping the Grammars package. Syntax highlighting was working. |
I got the same when I tried that to get the System.Text.Json update - Visual Studio says this: I haven't had time to look at anything beyond that. |
I'd guess caused by danipen/TextMateSharp#59 - |
Ah, I may be able to take a look at that tonight. It's a little concerning that the stack trace gets buried... maybe that's the configuration of my app though. |
I tried checking out AvaloniaEdit As @Numpsy showed there's a breaking change in TextMateSharp where some int fields are changed into the FontStyle enum. So the current version of AvaloniaEdit on Nuget isn't compatible with versions of TextMateSharp > I'm pretty confused why I don't see an exception being thrown. Perhaps dotnet is happy to do this conversion between ints and the enum when I'm using pre-compiled byte-code or something. Things do compile and the demo runs normally against master (This PR) though. I think there just needs to be a newer version of AvaloniaEdit released to resolve the issue. |
@Takoooooo please could you do that? |
@danipen I can do a new release. But should I include this PR? If you want it to be compatible with a new text mate. |
Well ... the PR that fixes the issue is this one #441. Also note that the TextMateSahrp API changed some versions ago (at version 1.0.56). The API change is minimal (it's just changing a int type by an enum) so I think we're ok going with it and merging this PR. |
Bumps TextMateSharp version to latest, which allows usage of changes from danipen/TextMateSharp#67