Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/radio): Update UI state when removed from radio #315

Merged
merged 2 commits into from
May 1, 2022

Conversation

antond15
Copy link
Contributor

@antond15 antond15 commented Apr 29, 2022

This fixes a issue of UI not updating after being rejected to join a radio channel.

@antond15
Copy link
Contributor Author

antond15 commented May 1, 2022

Sorry for the weird commit history. It should be okay now.

@AvarianKnight
Copy link
Owner

Why send updateUi? If its the local player then just remove no matter what

@antond15
Copy link
Contributor Author

antond15 commented May 1, 2022

Why send updateUi? If its the local player then just remove no matter what

You're right 👍🏼

@AvarianKnight
Copy link
Owner

Make sure to remove updateUi as an argument too

@AvarianKnight AvarianKnight merged commit 3863673 into AvarianKnight:main May 1, 2022
@antond15 antond15 deleted the ui-fix branch May 1, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants