Skip to content

Commit

Permalink
kselftest/arm64: Don't leak pipe fds in pac.exec_sign_all()
Browse files Browse the repository at this point in the history
[ Upstream commit 27141b690547da5650a420f26ec369ba142a9ebb ]

The PAC exec_sign_all() test spawns some child processes, creating pipes
to be stdin and stdout for the child. It cleans up most of the file
descriptors that are created as part of this but neglects to clean up the
parent end of the child stdin and stdout. Add the missing close() calls.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20241111-arm64-pac-test-collisions-v1-1-171875f37e44@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
broonie authored and Avenger-285714 committed Dec 15, 2024
1 parent 607d775 commit 3888c88
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/testing/selftests/arm64/pauth/pac.c
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ int exec_sign_all(struct signatures *signed_vals, size_t val)
return -1;
}

close(new_stdin[1]);
close(new_stdout[0]);

return 0;
}

Expand Down

0 comments on commit 3888c88

Please sign in to comment.