Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVX-55377: fix handling of insufficient JIRA configuration #5

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

tycho
Copy link
Contributor

@tycho tycho commented Jul 30, 2024

get_client should have a name explaining what it actually does (client for what?)

The jira function needs to assert that client and username are not None in order to avoid faulting. The logging lines were also not correctly written, because:

  File "/codebuild/output/src1691141165/src/actions-runner/_work/cloudn/cloudn/cloudn/test-scripts/end-to-end/.venv/lib/python3.10/site-packages/pytest_testrail/plugin.py", line 393, in jira
    logger.info("username" + username)
TypeError: can only concatenate str (not "NoneType") to str

Signed-off-by: Steven Noonan <snoonan@aviatrix.com>
@tycho tycho requested a review from jamincollins July 30, 2024 22:44
@jamincollins jamincollins merged commit 0e13ab5 into main Jul 30, 2024
2 checks passed
@jamincollins jamincollins deleted the steven/handle-incorrect-jira-configuration branch July 30, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants