-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning #776
Add warning #776
Conversation
for more information, see https://pre-commit.ci
This is a good idea; I had this in #775 earlier but it generated quite a few messages when starting a cutax context. But maybe that's OK, or you want to merge this after fixing straxen/cutax first. |
For straxen I did: XENONnT/straxen#1292 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I assume you want to wait until at least https://github.com/XENONnT/cutax/pull/317 is merged to avoid a swarm of warning messages, but from the strax side I don't see any problems.
(Well, there is a typo in the message, overlap dregister
should probably be overlaps registered
, but I guess it reinforces the message that you should not be seeing this message ;-)
The set
doesn't change any behavior I think due to the check if old_plugin == currently_registered
, but I think it make things clearer. (The purpose is to deregister plugins once for each datatype.)
Thanks @JelleAalbers, I fixed the typo. Regarding the |
Add a small user warning if a plugin is deregistered as this is should be not a normal use case. Also converts list of plugins to deregistered into a set to avoid duplication. Small addition to: https://github.com/AxFoundation/strax/pull/775/files