Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save data_start even there is no downsampling #909

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Further, fix #867 (comment). As said in that conversation, People might misunderstand the non-downsampled data_start if they are zero.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@dachengx dachengx requested a review from HenningSE October 16, 2024 02:52
@dachengx dachengx marked this pull request as ready for review October 16, 2024 02:52
@coveralls
Copy link

coveralls commented Oct 16, 2024

Coverage Status

coverage: 90.198%. remained the same
when pulling 0cd9988 on save_data_start
into 7bdb03f on master.

@HenningSE
Copy link
Collaborator

Thanks, @dachengx we can do it like this! Do you still want to keep the upper limit for the downsampling factor? It was introduced to save disk space and keep data_start for S2s at 0. To avoid further confusion, we could also remove this limit if you want.

@dachengx
Copy link
Collaborator Author

dachengx commented Oct 16, 2024

Thanks, @dachengx we can do it like this! Do you still want to keep the upper limit for the downsampling factor? It was introduced to save disk space and keep data_start for S2s at 0. To avoid further confusion, we could also remove this limit if you want.

Maybe yes. I will update #910.

@dachengx dachengx merged commit 10b6363 into master Oct 16, 2024
7 of 8 checks passed
@dachengx dachengx deleted the save_data_start branch October 16, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants