Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compute_center_times from straxen to strax #938

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

dachengx
Copy link
Collaborator

What is the problem / what does the code in this PR do

Can you briefly describe how it works?

Besides moving, two small changes are made:

  1. add dt / 2 to center_time
  2. add time in the function (so center_time should be np.int64)

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

  • Update the docstring(s)
  • Update the documentation
  • Tests to check the (new) code is working as desired.
  • Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

@coveralls
Copy link

Coverage Status

coverage: 89.181% (-0.09%) from 89.274%
when pulling 65e4bba on move_compute_center_times
into 956031e on master.

@dachengx dachengx marked this pull request as ready for review December 18, 2024 19:01
@dachengx dachengx merged commit 831c4ee into master Dec 18, 2024
8 checks passed
@dachengx dachengx deleted the move_compute_center_times branch December 18, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants