Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace GfFieldWithProductFieldSetting.productField with .connectedProductField. #435

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

justlevine
Copy link
Member

What

This PR deprecates the (int) GfFieldWithProductFieldSetting.productField in favor of (ProductField) .connectedProductField.

Why

How

Testing Instructions

Additional Info

Checklist:

  • This PR is tested to the best of my abilities.
  • This PR follows the WordPress Coding Standards.
  • This PR has proper inline documentation.
  • This PR has unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine merged commit 65a2fa1 into AxeWP:develop Jun 15, 2024
6 of 7 checks passed
@justlevine justlevine deleted the feat/connected-product-field branch June 15, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant