Refactor + Test Coverage + Nuget Deploy #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release workflow should now deploy the new version to nuget
Written the test cases for the localization manager. I've moved some logic out into its own class since its much easier to test in isolation. Init now returns a value, I'm undecided whether to handle the false in the maui init layer. I will need to test before I decide on that!
Lots of updates, I'm not touching Moq until I know the latest version is actually safe from spyware.
There is now test coverage for this class, I identified a bug where i could save a totally invalid culture because the ctor for cultureinfo doesn't throw. The lib now checks that culture string exists before trying to create culture object
There is now good coverage for this class, turns out i introduced a bug when refactoring so good thing I did these before pr :D
|
#14 Related |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 4e4ab67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI should now deploy to nuget automatically.
To help test this out i've written some tests for the library. I'm realising there is no way to use the lib without an external provider so I probably need to have a think about the architecture, for now it works for me so will ship this as a prerelease