Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repetitive log messages #244

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Remove repetitive log messages #244

merged 1 commit into from
Apr 30, 2024

Conversation

killenheladagen
Copy link
Contributor

@killenheladagen killenheladagen commented Apr 30, 2024

If AXParameter or environment variable setup fails, a detailed message is already logged in the failing function. There is no need to repeat that message with less detail at the call site.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

If AXParameter or environment variable setup fails,
a detailed message is already logged in the failing function.
There is no need to repeat that message with less detail at the call site.
@killenheladagen killenheladagen requested review from a team as code owners April 30, 2024 13:05
@killenheladagen killenheladagen merged commit eedaa05 into main Apr 30, 2024
13 checks passed
@killenheladagen killenheladagen deleted the rm-double-error branch April 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants