Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTTP requests one-by-one #147

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Handle HTTP requests one-by-one #147

merged 1 commit into from
Apr 25, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This is an automatic cherry-pick of 1b71543bc99587dccabad770929fe6c47c3913f2

The original PR was #238 with message:

By handling HTTP requests one-by-one rather than spawning a thread for each request, an attacker can no longer force the app to create multiple threads. It also leads to simpler code and fixes the failure to free the memory allocated for the request.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

By handling HTTP requests one-by-one rather than spawning a thread for
each request, an attacker can no longer force the app to create
multiple threads. It also leads to simpler code and fixes the failure
to free the memory allocated for the request.
@github-actions github-actions bot requested review from a team as code owners April 25, 2024 07:20
@killenheladagen killenheladagen merged commit 5fa166a into main Apr 25, 2024
@killenheladagen killenheladagen deleted the cherrybot-19540 branch April 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant