Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse bug #241

Closed
AykutSarac opened this issue Oct 15, 2022 · 4 comments · Fixed by #243
Closed

Collapse bug #241

AykutSarac opened this issue Oct 15, 2022 · 4 comments · Fixed by #243
Labels
bug Something isn't working roadmap Part of the roadmap

Comments

@AykutSarac
Copy link
Owner

    @AykutSarac The bug is present on `production` and is unrelated to this ticket.

I suggest opening a new issue for this bug.

Screen.Recording.2022-10-05.at.22.02.44.mov

You can reproduce it by using this JSON:

{ "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [] } ] } ] } ] }

Originally posted by @VladCuciureanu in #230 (comment)

@AykutSarac AykutSarac added bug Something isn't working roadmap Part of the roadmap hacktoberfest labels Oct 15, 2022
@mintbomb27
Copy link

Hey! I'd like to work on this!

@mintbomb27
Copy link

@AykutSarac Is the expected working of this issue to expand all the children, or just expand till the next level of the graph?

@VladCuciureanu
Copy link
Contributor

@mintbomb27

  1. Use this json (or any depth >= 4 json):
    { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [] } ] } ] } ] }
  2. Close the graph nodes one by one, from leaf to root
  3. Expand the first node

At this point, in the video at 0:04, you can see other nodes appear besides the expected one (the disconnected node is not expected)

@shivam1646
Copy link
Contributor

@AykutSarac I've created PR #243 to fix this issue. Could you please take a look when you get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working roadmap Part of the roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants