Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a 'Collapse/Expand Graph' button #230

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Added a 'Collapse/Expand Graph' button #230

merged 1 commit into from
Oct 6, 2022

Conversation

VladCuciureanu
Copy link
Contributor

Solves #188

This PR implements a Expand/Collapse Graph button in the sidebar that does exactly what the name implies.

Screen.Recording.2022-10-05.at.15.58.55.mov

@AykutSarac
Copy link
Owner

Thank you for your contribution! The main task here is to collapse all parent nodes, not only the main. So one will expand nodes one by one once all are collapsed, currently it only collapses parent node. Is it possible to achieve that?

@VladCuciureanu
Copy link
Contributor Author

VladCuciureanu commented Oct 5, 2022

Thank you for your contribution! The main task here is to collapse all parent nodes, not only the main. So one will expand nodes one by one once all are collapsed, currently it only collapses parent node. Is it possible to achieve that?

I misinterpreted that. Updated implementation. Hope this is ok.

Screen.Recording.2022-10-05.at.20.27.27.mov

@AykutSarac
Copy link
Owner

Thank you! It works but I think there's a bug, if you expand one by one you can see parents appearing after their parent expanded. I tested it on this https://www.reddit.com/r/all.json

@VladCuciureanu
Copy link
Contributor Author

VladCuciureanu commented Oct 5, 2022

@AykutSarac The bug is present on production and is unrelated to this ticket.
I suggest opening a new issue for this bug.

Screen.Recording.2022-10-05.at.22.02.44.mov

You can reproduce it by using this JSON:

{ "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [ { "test": "test", "members": [] } ] } ] } ] }

@AykutSarac AykutSarac linked an issue Oct 6, 2022 that may be closed by this pull request
@AykutSarac AykutSarac merged commit 679fc70 into AykutSarac:main Oct 6, 2022
@AykutSarac AykutSarac mentioned this pull request Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need collapse all nodes button
2 participants