Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: persist hidden nodes on rotate #238

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

shivam1646
Copy link
Contributor

resolves #173

  • Doesn't clear hidden nodes, edges on layout change.
  • Triggers the side effect to hide nodes on layout change.

json_rotate

@AykutSarac
Copy link
Owner

Thanks for the contribution! Why did you prefer a specific setLoading method over setGraphValue?

@shivam1646
Copy link
Contributor Author

@AykutSarac
The idea was to not reset these values - collapsedParents, collapsedNodes, collapsedEdges whenever layout changes. Hence I call setLoading instead of setGraphValue (this resets all the collapsed items to []) on layout change.

Could also modify setGraphValue instead, such that it would conditionally reset the collapsed items.

@AykutSarac
Copy link
Owner

Makes sense! Thanks for the contribution again!

@AykutSarac AykutSarac merged commit 0737bcb into AykutSarac:main Oct 12, 2022
@shivam1646
Copy link
Contributor Author

Thanks @AykutSarac
Also, json crack is an awesome product. Would love to make more meaningful contributions in the future!

@shivam1646
Copy link
Contributor Author

@AykutSarac could you also please add the hacktoberfest-accepted label ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: When rotated, hidden node showed up. need to "click hide" again to hide it.
2 participants