Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed array length doesn't update #349

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Fixed array length doesn't update #349

merged 1 commit into from
Aug 18, 2023

Conversation

prathameshjchavan
Copy link
Contributor

Fixes #345

  • The TextNode component is not being re-rendered when the 'childrenCount' is updating.
  • Added the condition that when it changes, it should re-render the component
  • Changes are made in the propsAreEqual function.
fix.mp4

@AykutSarac AykutSarac merged commit 282dfe5 into AykutSarac:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AykutSarac AykutSarac AykutSarac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Array Length doesn't update when adding elements.
2 participants
@prathameshjchavan @AykutSarac