Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev csv #761

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Dev csv #761

merged 4 commits into from
Apr 2, 2022

Conversation

annapanni
Copy link
Contributor

This patch enables users to upload cultures from a csv file (compatible with the exported csv).

@Azgaar Azgaar self-requested a review March 25, 2022 07:35
@Azgaar
Copy link
Owner

Azgaar commented Mar 25, 2022

Hello, thanks for the contribution. It looks promising, but I need more time to check it out.

modules/ui/cultures-editor.js Outdated Show resolved Hide resolved
@Azgaar
Copy link
Owner

Azgaar commented Mar 31, 2022

There is one small item that probably should be fixed

@annapanni annapanni requested a review from Azgaar April 2, 2022 13:28
@Azgaar Azgaar merged commit af62ff9 into Azgaar:master Apr 2, 2022
@Azgaar
Copy link
Owner

Azgaar commented Apr 2, 2022

Merging, thanks for the PR and sorry that it took a lot of time

@annapanni annapanni deleted the dev-csv branch April 26, 2022 19:56
sofronaspe pushed a commit to sofronaspe/Fantasy-Map-Generator that referenced this pull request Nov 22, 2022
* import cultures feature

* remove debug messages

* code cleanup
sofronaspe pushed a commit to sofronaspe/Fantasy-Map-Generator that referenced this pull request Nov 27, 2022
* import cultures feature

* remove debug messages

* code cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants