Turkish culture fixes #968
Conversation
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello and thanks for the contribution! |
|
Thank you for accepting the changes. I have updated the file with shorter namebase. Turkic states using -stan suffix is very modern. Oldest Turkic country ever used -stan in their name is just after collapse of USSR first time ever used is 1991. In the name generation it used to generate province names it's not correct usage. It's only used for country names. |
I am not really interested in this discussion, what is modern and what is not, but it sounds very misleading. Turkic countries with -stan got their independence in 1991, but the names were used centuries before that and have long history or transformations/migrations and interpretations. Like the term Turkestan is known from 7th century AD. Most of current -stan regions use this name from the very beginning on the national building movement (mid 19th century), so there were no other widely accepted names before that. |
|
I want to fix "Beylik" names. Assume counrty name is "Alayurt" it generates "Alayurt Beylik" is not ok "Alayurt Beylik" is lacking possesive. Correct name generation would be "Alayurt Beyligi" |
The tool is in English, so only English is fully supported. Like other languages also have it's own rules and cases, but we don't follow them for simplicity. That's why we only have English letters in the default namesbases, not diacritics as it's read differently by different people, while we want our names be readable. |
In this case there is nothing more to change I thinkt it's ready to merge. |
Description
Name generation
The Turkish name generation wasn't working well. Names generated by the system didn't feel like Turkish at all. The reason behind this is city names of Turkey were used as the name base. However, most cities in Turkey got their names before Turks moved to Anatolia. The second problem is Turkish characters like "Ş" converted to "SH" and "ı" converted to "i" or sometimes "y," so it lost all readability and cultural references.
New names were chosen from real Turkic origin names (the ones without Turkish characters, so no Turkish character conversions). I've tried many times with your name generator, and it worked very well.
Wrong province suffix
The second problem is provinces in Turkic culture end with "eli" or "yurt," but the file was using a Persian suffix "-stan." So, the Persian suffix has been removed, and Turkic suffixes have been added.
Wrong country extension generation
Khan, Kaan, Kağan, Han are all Turkic-origin words. In the whole history, Turks always called their leaders Khan. Only during the Ottoman Empire, for a short period, Ottoman Khan was called "Sultan" alongside "Han." Sultan was used because the Ottoman Empire was ruling Arabic geography. Turks continued to call the leader "Han." Actually, it became a custom to use both titles at the same time, like "Sultan Süleyman Han."
A quick Wikipedia check shows that Turks had many Khanates and zero Sultanates.
https://en.wikipedia.org/wiki/Khanate#Turkic_khanates
Type of change
Versioning