State labels: new label placing algorithm #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New placing algorithm for state labels - now state labels should be less curvy and take more optimal position. Migrated from #842 with a few issues fixed.
Old Algorithm:
Custom implementation of the centerline labeling. Build voronoi to define a centerline and place label based on it.
https://observablehq.com/@veltman/centerline-labeling
Pros:
Cons:
New algorithm:
For each state we cast rays from the state's pole of inaccessibility to define which label position is optimal. Horizontal positions take advantage, vertical is discouraged.
Pros:
Const:
Type of change
Versioning