Skip to content

Commit

Permalink
refactor: aztec-node json-rpc (#2444)
Browse files Browse the repository at this point in the history
This PR replaces the HTTP rest API exposed by `rollup-provider` with a
JSON-RPC server for `AztecNode`. ATM the `@aztec/aztec-node` package
exports both the server and client implementation but it might make
sense to move the JSON-RPC client to its own package.

Along the way I had to update some of the models to make them
serialisable to/from strings. I have added tests as needed.

I have also removed `rollup-provider` since that seemed to no longer
used and it was a just thin wrapper around an `AztecNode` and its REST
API.

See also #2358 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
  • Loading branch information
alexghr authored Sep 22, 2023
1 parent a8aec70 commit 04efee1
Show file tree
Hide file tree
Showing 28 changed files with 156 additions and 1,438 deletions.
13 changes: 0 additions & 13 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -671,17 +671,6 @@ jobs:
name: "Build"
command: build ethereum

rollup-provider:
machine:
image: ubuntu-2004:202010-01
resource_class: large
steps:
- *checkout
- *setup_env
- run:
name: "Build"
command: build rollup-provider

e2e-2-rpc-servers:
machine:
image: ubuntu-2004:202010-01
Expand Down Expand Up @@ -1429,7 +1418,6 @@ workflows:
- sequencer-client: *yarn_project
- types: *yarn_project
- circuits-js: *yarn_project
- rollup-provider: *yarn_project
- aztec-sandbox-base: *yarn_project
- canary: *yarn_project

Expand Down Expand Up @@ -1470,7 +1458,6 @@ workflows:
- sequencer-client
- types
- circuits-js
- rollup-provider
- aztec-sandbox-ecr-manifest
- canary
<<: *defaults
Expand Down
6 changes: 1 addition & 5 deletions build_manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,6 @@
"buildDir": "yarn-project",
"projectDir": "yarn-project/prover-client"
},
"rollup-provider": {
"buildDir": "yarn-project",
"projectDir": "yarn-project/rollup-provider"
},
"aztec-node": {
"buildDir": "yarn-project",
"projectDir": "yarn-project/aztec-node"
Expand All @@ -240,4 +236,4 @@
"buildDir": "yarn-project",
"projectDir": "yarn-project/world-state"
}
}
}
Loading

0 comments on commit 04efee1

Please sign in to comment.