CI fix

AztecProtocol · Aug 16, 2023 · 09bbe62 · 09bbe62
1 parent 28142c8
commit 09bbe62
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/yarn-project/end-to-end/src/e2e_aztec_js_browser.test.ts b/yarn-project/end-to-end/src/e2e_aztec_js_browser.test.ts
@@ -126,7 +126,7 @@ conditionalDescribe()('e2e_aztec.js_browser', () => {
     const accounts = await testClient.getAccounts();
     const stringAccounts = accounts.map(acc => acc.address.toString());
     expect(stringAccounts.includes(result)).toBeTruthy();
-  });
+  }, 15_000);
 
   it('Deploys Private Token contract', async () => {
     const txHash = await page.evaluate(

diff --git a/yarn-project/foundation/src/json-rpc/client/json_rpc_client.ts b/yarn-project/foundation/src/json-rpc/client/json_rpc_client.ts
@@ -47,7 +47,7 @@ export async function defaultFetch(host: string, rpcMethod: string, body: any, u
     throw new Error(`Failed to parse body as JSON: ${resp.text()}`);
   }
   if (!resp.ok) {
-    throw new Error(responseJson.error);
+    throw new Error(responseJson.error, { cause: 'thrownByServer' });
   }
 
   return responseJson;

diff --git a/yarn-project/foundation/src/retry/index.ts b/yarn-project/foundation/src/retry/index.ts
@@ -38,6 +38,12 @@ export async function retry<Result>(
     try {
       return await fn();
     } catch (err: any) {
+      if (err.cause == 'thrownByServer') {
+        // If the error is specifically marked as thrown by the server, we don't retry because the error should be
+        // propagated. This is because it's an "intentional error" (e.g. "Contract is not deployed") and not
+        // a connection error or an unexpected software bug.
+        throw err;
+      }
       const s = backoff.next().value;
       if (s === undefined) {
         throw err;