Skip to content

Commit

Permalink
fix: docker-compose up, rather than run. (#3081)
Browse files Browse the repository at this point in the history
`docker run` seems to be exposing race conditions in how certain tests
start. e.g. guides/*
Reverting to `docker up`, although worried it's masking issues.
  • Loading branch information
charlielye authored Oct 27, 2023
1 parent 15db6bf commit 242f780
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build-system/scripts/cond_run_compose
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if ! check_rebuild $SUCCESS_TAG $REPOSITORY; then
cd $(query_manifest projectDir $REPOSITORY)

export $@
docker-compose -f $COMPOSE_FILE run $REPOSITORY
docker-compose -f $COMPOSE_FILE up --exit-code-from $REPOSITORY --force-recreate

upload_logs_to_s3 log

Expand Down
2 changes: 1 addition & 1 deletion yarn-project/end-to-end/scripts/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ services:
environment:
BENCHMARK: 'true'
LOG_LEVL: 'debug'
DEBUG: ${DEBUG:-'aztec:*'}
DEBUG: ${DEBUG:-aztec:*}
ETHEREUM_HOST: http://fork:8545
CHAIN_ID: 31337
PXE_URL: http://sandbox:8080
Expand Down

0 comments on commit 242f780

Please sign in to comment.