cleanup, todos, and avm gen updates

AztecProtocol · Jun 28, 2024 · 3cb9179 · 3cb9179
1 parent eb1e87d
commit 3cb9179
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp b/barretenberg/cpp/src/barretenberg/commitment_schemes/zeromorph/zeromorph.hpp
@@ -399,7 +399,7 @@ template <typename Curve> class ZeroMorphProver_ {
             std::string label = "ZM:C_q_" + std::to_string(idx);
             transcript->send_to_verifier(label, q_k_commitment);
         }
-
+        // Add buffer elements to remove log_N dependence in proof
         for (size_t idx = log_N; idx < CONST_PROOF_SIZE_LOG_N; ++idx) {
             auto buffer_element = Commitment::one();
             std::string label = "ZM:C_q_" + std::to_string(idx);

diff --git a/barretenberg/cpp/src/barretenberg/eccvm_recursion/eccvm_recursive_verifier.cpp b/barretenberg/cpp/src/barretenberg/eccvm_recursion/eccvm_recursive_verifier.cpp
@@ -79,7 +79,6 @@ template <typename Flavor> void ECCVMRecursiveVerifier_<Flavor>::verify_proof(co
     auto [multivariate_challenge, claimed_evaluations, sumcheck_verified] =
         sumcheck.verify(relation_parameters, alpha, gate_challenges);
 
-    // WORKTODO: circuit size nonsense
     auto multivariate_to_univariate_opening_claim = ZeroMorph::verify(circuit_size,
                                                                       commitments.get_unshifted(),
                                                                       commitments.get_to_be_shifted(),

diff --git a/barretenberg/cpp/src/barretenberg/polynomials/pow.hpp b/barretenberg/cpp/src/barretenberg/polynomials/pow.hpp
@@ -69,9 +69,6 @@ template <typename FF> struct PowPolynomial {
      */
     template <typename Bool> FF univariate_eval(const FF& challenge, const Bool& dummy_round) const
     {
-        // WORKTODO: The real problem here is that we need to have MAX_LOG betas in every case so we really dont need a
-        // conditional. The fact that we dont have MAX betas is only wokring because we dont add gates for hashing in
-        // ultra.
         FF beta_or_dummy;
         if (!dummy_round.get_value()) {
             beta_or_dummy = betas[current_element_idx];

diff --git a/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp b/barretenberg/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup.test.cpp
@@ -443,8 +443,8 @@ template <typename TestType> class stdlib_biggroup : public testing::Test {
 
     static void test_batch_mul()
     {
-        // WORKTODO: issue that this test will fail with num_points is 1 (and this case gets hit sometimes when handling
-        // points at infinity).
+        // TODO(https://github.com/AztecProtocol/barretenberg/issues/1043): this test will fail with num_points is 1
+        // (and this case gets hit sometimes when handling points at infinity).
         const size_t num_points = 5;
         Builder builder;
         std::vector<affine_element> points;

diff --git a/bb-pilcom/bb-pil-backend/src/verifier_builder.rs b/bb-pilcom/bb-pil-backend/src/verifier_builder.rs
@@ -56,7 +56,7 @@ impl VerifierBuilder for BBFiles {
             |public_inputs_column_name: &String, idx: usize| {
                 format!(
                 "
-        FF {public_inputs_column_name}_evaluation = evaluate_public_input_column(public_inputs[{idx}], circuit_size, multivariate_challenge);
+        FF {public_inputs_column_name}_evaluation = evaluate_public_input_column(public_inputs[{idx}], circuit_size, mle_challenge);
         if ({public_inputs_column_name}_evaluation != claimed_evaluations.{public_inputs_column_name}) {{
             return false;
         }}
@@ -178,6 +178,8 @@ impl VerifierBuilder for BBFiles {
         }}
 
         // Public columns evaluation checks
+        std::vector<FF> mle_challenge(multivariate_challenge.begin(),
+                                  multivariate_challenge.begin() + static_cast<int>(log_circuit_size));
         {public_inputs_check}
     
         // Execute ZeroMorph rounds. See https://hackmd.io/dlf9xEwhTQyE3hiGbq4FsA?view for a complete description of the