fix: padded printing for e2e-cli (#2106)

This fixes a 1 in 256 chance of failure when the last hex byte was 00.
AztecProtocol · Sep 7, 2023 · 5988014 · 5988014
1 parent c6890fe
commit 5988014
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/yarn-project/cli/src/index.ts b/yarn-project/cli/src/index.ts
@@ -113,7 +113,7 @@ export function getProgram(log: LogFn, debugLogger: DebugLogger): Command {
         publicKey = await generatePublicKey(key);
       } else {
         const key = GrumpkinScalar.random();
-        privKey = key.toString();
+        privKey = key.toString(true);
         publicKey = await generatePublicKey(key);
       }
       log(`\nPrivate Key: ${privKey}\nPublic Key: ${publicKey.toString()}\n`);
@@ -144,7 +144,7 @@ export function getProgram(log: LogFn, debugLogger: DebugLogger): Command {
       log(`\nCreated new account:\n`);
       log(`Address:         ${address.toString()}`);
       log(`Public key:      ${publicKey.toString()}`);
-      if (!options.privateKey) log(`Private key:     ${privateKey.toString()}`);
+      if (!options.privateKey) log(`Private key:     ${privateKey.toString(true)}`);
       log(`Partial address: ${partialAddress.toString()}`);
     });
 

diff --git a/yarn-project/foundation/src/fields/grumpkin_scalar.ts b/yarn-project/foundation/src/fields/grumpkin_scalar.ts
@@ -108,10 +108,11 @@ export class GrumpkinScalar {
    * The resulting string is prefixed with '0x' and contains the exact number of hex characters required
    * to represent the numeric value of this instance.
    *
+   * @param padTo32 - Whether to pad the resulting string to 32 bytes.
    * @returns A hexadecimal string representing the GrumpkinScalar value.
    */
-  toString() {
-    return toHex(this.value);
+  toString(padTo32 = false) {
+    return toHex(this.value, padTo32);
   }
 
   /**