Skip to content

Commit

Permalink
fix: PATH and bb.js ref
Browse files Browse the repository at this point in the history
  • Loading branch information
ludamad committed Sep 18, 2023
1 parent d4f5a81 commit 5c46977
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
5 changes: 3 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ checkout: &checkout
setup_env: &setup_env
run:
name: "Setup environment"
command: ./build-system/scripts/setup_env "$CIRCLE_SHA1" "$CIRCLE_TAG" "$CIRCLE_JOB" "$CIRCLE_REPOSITORY_URL" "$CIRCLE_BRANCH"
command: |
./build-system/scripts/setup_env "$CIRCLE_SHA1" "$CIRCLE_TAG" "$CIRCLE_JOB" "$CIRCLE_REPOSITORY_URL" "$CIRCLE_BRANCH"
# This step is used to save logs from various barretenberg test to the workspace so that they can be used later to parse benchmark values out of them
save_logs: &save_logs
Expand Down Expand Up @@ -376,6 +377,7 @@ jobs:
- run:
name: Build
command: |
echo $PATH
which build
which jq
which yq
Expand All @@ -385,7 +387,6 @@ jobs:
yarn-project-base:
machine:
image: ubuntu-2204:2023.07.2
resource_class: large
steps:
- *checkout
- *setup_env
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/ts/scripts/run_tests
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ set -xe

$(aws ecr get-login --region us-east-2 --no-include-email) 2> /dev/null

REPOSITORY=bb.js
REPOSITORY=bb-js
IMAGE_URI=$($(git rev-parse --show-toplevel)/build-system/scripts/calculate_image_uri $REPOSITORY)
docker run --rm $IMAGE_URI
2 changes: 1 addition & 1 deletion build-system/scripts/build
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# - Perform the build of the image itself. With the cache primed we should only have to rebuild the necessary layers.
# - Push the image tagged with the commit hash to the cache.

set -euo pipefail
set -xeuo pipefail

REPOSITORY=$1
FORCE_BUILD=${2:-"false"}
Expand Down
2 changes: 1 addition & 1 deletion build-system/scripts/calculate_content_hash
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash

set -eu
set -exu

REPOSITORY=$1
COMMIT_HASH=${2:-${COMMIT_HASH:-$(git rev-parse HEAD)}}
Expand Down
2 changes: 1 addition & 1 deletion build-system/scripts/calculate_image_uri
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -eu
set -exu

REPOSITORY=$1
# Assume we might be calling this directly without build system in path
Expand Down
2 changes: 1 addition & 1 deletion build-system/scripts/setup_env
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ echo export ROOT_PATH=$PWD >> $BASH_ENV
echo export BUILD_SYSTEM_PATH=$BUILD_SYSTEM_PATH >> $BASH_ENV
echo export DOCKER_BUILDKIT=${DOCKER_BUILDKIT:-1} >> $BASH_ENV
echo export SSH_CONFIG_PATH=$BUILD_SYSTEM_PATH/remote/ssh_config >> $BASH_ENV
echo export PATH=$PATH:$BUILD_SYSTEM_PATH/scripts >> $BASH_ENV
echo export PATH=\$PATH:$BUILD_SYSTEM_PATH/scripts >> $BASH_ENV
echo export AWS_DEFAULT_REGION=eu-west-2 >> $BASH_ENV
echo export ECR_REGION=us-east-2 >> $BASH_ENV
echo export AWS_ACCOUNT=278380418400 >> $BASH_ENV
Expand Down

0 comments on commit 5c46977

Please sign in to comment.