Skip to content

Commit

Permalink
test: check root parity is only enqueued once its deps are ready
Browse files Browse the repository at this point in the history
  • Loading branch information
alexghr committed Apr 25, 2024
1 parent 4cee8e0 commit a2bc212
Showing 1 changed file with 69 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
import {
Fr,
NUM_BASE_PARITY_PER_ROOT_PARITY,
type ParityPublicInputs,
type Proof,
makeEmptyProof,
} from '@aztec/circuits.js';
import { makeGlobalVariables, makeParityPublicInputs } from '@aztec/circuits.js/testing';
import { promiseWithResolvers } from '@aztec/foundation/promise';
import { sleep } from '@aztec/foundation/sleep';
import { openTmpStore } from '@aztec/kv-store/utils';
import { type MerkleTreeOperations, MerkleTrees } from '@aztec/world-state';

import { type MockProxy, mock } from 'jest-mock-extended';

import { makeEmptyProcessedTestTx } from '../mocks/fixtures.js';
import { type CircuitProver } from '../prover/index.js';
import { ProvingOrchestrator } from './orchestrator.js';

describe('prover/orchestrator', () => {
describe('workflow', () => {
let orchestrator: ProvingOrchestrator;
let mockProver: MockProxy<CircuitProver>;
let actualDb: MerkleTreeOperations;
beforeEach(async () => {
actualDb = await MerkleTrees.new(openTmpStore()).then(t => t.asLatest());
mockProver = mock<CircuitProver>();
orchestrator = new ProvingOrchestrator(actualDb, mockProver);
});

it.skip('calls root parity circuit only when ready', async () => {
// create a custom L2 to L1 message
const message = Fr.random();

// and delay its proof
const pendingBaseParityResult = promiseWithResolvers<[ParityPublicInputs, Proof]>();
const expectedBaseParityResult: [ParityPublicInputs, Proof] = [makeParityPublicInputs(), makeEmptyProof()];

mockProver.getRootParityProof.mockResolvedValue([makeParityPublicInputs(), makeEmptyProof()]);

mockProver.getBaseParityProof.mockImplementation(inputs => {
if (inputs.msgs[0].equals(message)) {
return pendingBaseParityResult.promise;
} else {
return Promise.resolve([makeParityPublicInputs(), makeEmptyProof()]);
}
});

await orchestrator.startNewBlock(2, makeGlobalVariables(1), [message], await makeEmptyProcessedTestTx(actualDb));

await sleep(10);
expect(mockProver.getBaseParityProof).toHaveBeenCalledTimes(NUM_BASE_PARITY_PER_ROOT_PARITY);
expect(mockProver.getRootParityProof).not.toHaveBeenCalled();

await sleep(10);
// even now the root parity should not have been called
expect(mockProver.getRootParityProof).not.toHaveBeenCalled();

// only after the base parity proof is resolved, the root parity should be called
pendingBaseParityResult.resolve(expectedBaseParityResult);

// give the orchestrator a chance to calls its callbacks
await sleep(10);
expect(mockProver.getRootParityProof).toHaveBeenCalledTimes(1);

orchestrator.cancelBlock();
});
});
});

0 comments on commit a2bc212

Please sign in to comment.