Skip to content

Commit

Permalink
final cleanups
Browse files Browse the repository at this point in the history
  • Loading branch information
maramihali committed Mar 4, 2024
1 parent 38107b1 commit aa35587
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 0 additions & 2 deletions barretenberg/cpp/src/barretenberg/client_ivc/client_ivc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ void ClientIVC::precompute_folding_verification_keys()
kernel_circuit, { function_fold_proof, vks.func_vk }, {}, initial_verifier_acc);
auto kernel_fold_proof = accumulate(kernel_circuit);
vks.first_kernel_vk = std::make_shared<VerificationKey>(prover_instance->proving_key);
;

// Create another mock function circuit to run the full kernel
function_circuit = ClientCircuit{ goblin.op_queue };
Expand All @@ -129,7 +128,6 @@ void ClientIVC::precompute_folding_verification_keys()
kernel_fold_proof = accumulate(kernel_circuit);

vks.kernel_vk = std::make_shared<VerificationKey>(prover_instance->proving_key);
;

// Clean the ivc state
goblin.op_queue = std::make_shared<Goblin::OpQueue>();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ template <typename BuilderType> class GoblinRecursiveVerifierTest : public testi
// Compute native verification key
InnerComposer inner_composer;
auto instance = inner_composer.create_prover_instance(inner_circuit);
// auto prover = inner_composer.create_prover(instance); // A prerequisite for computing VK
auto verification_key = std::make_shared<typename InnerFlavor::VerificationKey>(instance->proving_key);
// Instantiate the recursive verifier using the native verification key
RecursiveVerifier verifier{ &outer_circuit, verification_key };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ class GoblinUltraHonkComposerTests : public ::testing::Test {
using CommitmentKey = bb::CommitmentKey<Curve>;
using MergeProver = MergeProver_<GoblinUltraFlavor>;
using MergeVerifier = MergeVerifier_<GoblinUltraFlavor>;
using VerificationKey = GoblinUltraFlavor::VerificationKey;

/**
* @brief Generate a simple test circuit with some ECC op gates and conventional arithmetic gates
Expand Down Expand Up @@ -65,7 +64,7 @@ class GoblinUltraHonkComposerTests : public ::testing::Test {
{
auto instance = composer.create_prover_instance(builder);
auto prover = composer.create_prover(instance);
auto verification_key = std::make_shared<VerificationKey>(instance->proving_key);
auto verification_key = std::make_shared<GoblinUltraFlavor::VerificationKey>(instance->proving_key);
auto verifier = composer.create_verifier(verification_key);
auto proof = prover.construct_proof();
bool verified = verifier.verify_proof(proof);
Expand Down

0 comments on commit aa35587

Please sign in to comment.