Skip to content

Commit

Permalink
fix: merge-check (#5873)
Browse files Browse the repository at this point in the history
This was passing on skip. We may have to improve this logic in the
future.

Note: This wasn't done in github checks page because it can't list
matrix builds.
  • Loading branch information
ludamad authored Apr 19, 2024
1 parent ad55af0 commit c999dae
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,17 @@ jobs:
merge-check:
runs-on: ${{ github.actor }}-x86
needs: [e2e, bb-native-tests, bb-bench]
if: always() # Ensures this job runs regardless of the success or failure of dependencies.
steps:
- run: echo Pull request merging now allowed.
- run: |
echo "E2E Test Status: ${{ needs.e2e.result }}"
echo "Native Tests Status: ${{ needs.bb-native-tests.result }}"
echo "Bench Tests Status: ${{ needs.bb-bench.result }}"
if [[ "${{ needs.e2e.result }}" != 'success' || "${{ needs.bb-native-tests.result }}" != 'success' || "${{ needs.bb-bench.result }}" != 'success' ]]; then
echo "Pull request merging not allowed due to failures."
exit 1
fi
echo "Pull request merging now allowed."
notify:
needs: [e2e, bb-native-tests, bb-bench]
Expand Down

0 comments on commit c999dae

Please sign in to comment.