-
Notifications
You must be signed in to change notification settings - Fork 234
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: fail transaction if we revert in setup or teardown (#5093)
public-processor: Drop transactions that revert in non-revertible phases This change ensures that transactions are dropped if they revert in the setup or teardown phases, while still including transactions that revert only in the app logic phase. Changes: - Add `checkpoint`, `rollbackToCheckpoint`, `rollbackToCommit` methods to `PublicStateDB` - Update phase managers to use new `PublicStateDB` methods for checkpointing and rollbacks - Add assertions to setup and teardown public kernel circuits to fail if the public call is reverted - Add unit tests for `PublicProcessor` and `WorldStatePublicDB` - Add E2E tests with bugged `FeePaymentMethod`s to verify behavior Resolves: #4096
- Loading branch information
1 parent
6977e81
commit db9a960
Showing
16 changed files
with
608 additions
and
111 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ | |
"chainsafe", | ||
"cheatcode", | ||
"cheatcodes", | ||
"checkpointed", | ||
"checksummed", | ||
"cimg", | ||
"ciphertext", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.