Skip to content

Commit

Permalink
5466: positive unit tests for CAST
Browse files Browse the repository at this point in the history
  • Loading branch information
@jeanmon
jeanmon committed Apr 18, 2024
1 parent 86155a7 commit f0e34bb
Showing 1 changed file with 179 additions and 3 deletions.
182 changes: 179 additions & 3 deletions barretenberg/cpp/src/barretenberg/vm/tests/avm_cast.test.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,192 @@ class AvmCastTests : public ::testing::Test {

// TODO(640): The Standard Honk on Grumpkin test suite fails unless the SRS is initialised for every test.
void SetUp() override { srs::init_crs_factory("../srs_db/ignition"); };

void gen_trace(
uint128_t const& a, uint32_t src_address, uint32_t dst_address, AvmMemoryTag src_tag, AvmMemoryTag dst_tag)
{
trace_builder.op_set(0, a, src_address, src_tag);
trace_builder.op_cast(0, src_address, dst_address, dst_tag);
trace_builder.return_op(0, 0, 0);
trace = trace_builder.finalize();
}

void validate_cast_trace(FF const& a,
FF const& cast_val,
uint32_t src_address,
uint32_t dst_address,
AvmMemoryTag src_tag,
AvmMemoryTag dst_tag

)
{
auto row =
std::ranges::find_if(trace.begin(), trace.end(), [](Row r) { return r.avm_main_sel_op_cast == FF(1); });
ASSERT_TRUE(row != trace.end());

EXPECT_THAT(*row,
AllOf(Field("sel_op_cast", &Row::avm_main_sel_op_cast, 1),
Field("ia", &Row::avm_main_ia, a),
Field("ib", &Row::avm_main_ib, 0),
Field("ic", &Row::avm_main_ic, cast_val),
Field("r_in_tag", &Row::avm_main_r_in_tag, static_cast<uint32_t>(src_tag)),
Field("w_in_tag", &Row::avm_main_w_in_tag, static_cast<uint32_t>(dst_tag)),
Field("alu_in_tag", &Row::avm_main_alu_in_tag, static_cast<uint32_t>(dst_tag)),
Field("op_a", &Row::avm_main_mem_op_a, 1),
Field("op_c", &Row::avm_main_mem_op_c, 1),
Field("rwa", &Row::avm_main_rwa, 0),
Field("rwc", &Row::avm_main_rwc, 1),
Field("mem_idx_a", &Row::avm_main_mem_idx_a, src_address),
Field("mem_idx_c", &Row::avm_main_mem_idx_c, dst_address),
Field("tag_err", &Row::avm_main_tag_err, 0),
Field("alu_sel", &Row::avm_main_alu_sel, 1),
Field("sel_rng_8", &Row::avm_main_sel_rng_8, 1),
Field("sel_rng_16", &Row::avm_main_sel_rng_16, 1)));

// Find the corresponding Alu trace row
auto clk = row->avm_main_clk;
auto alu_row = std::ranges::find_if(trace.begin(), trace.end(), [clk](Row r) { return r.avm_alu_clk == clk; });
ASSERT_TRUE(alu_row != trace.end());

EXPECT_THAT(*alu_row,
AllOf(Field("op_cast", &Row::avm_alu_op_cast, 1),
Field("alu_ia", &Row::avm_alu_ia, a),
Field("alu_ib", &Row::avm_alu_ib, 0),
Field("alu_ic", &Row::avm_alu_ic, cast_val),
Field("u8_tag", &Row::avm_alu_u8_tag, dst_tag == AvmMemoryTag::U8),
Field("u16_tag", &Row::avm_alu_u16_tag, dst_tag == AvmMemoryTag::U16),
Field("u32_tag", &Row::avm_alu_u32_tag, dst_tag == AvmMemoryTag::U32),
Field("u64_tag", &Row::avm_alu_u64_tag, dst_tag == AvmMemoryTag::U64),
Field("u128_tag", &Row::avm_alu_u128_tag, dst_tag == AvmMemoryTag::U128),
Field("ff_tag", &Row::avm_alu_ff_tag, dst_tag == AvmMemoryTag::FF),
Field("in_tag", &Row::avm_alu_in_tag, static_cast<uint32_t>(dst_tag)),
Field("op_cast_prev", &Row::avm_alu_op_cast_prev, 0),
Field("lookup_selector", &Row::avm_alu_rng_chk_lookup_selector, 1),
Field("alu_sel", &Row::avm_alu_alu_sel, 1)));

// Check that there is a second ALU row
auto alu_row_next = alu_row + 1;
EXPECT_THAT(
*alu_row_next,
AllOf(Field("op_cast", &Row::avm_alu_op_cast, 0), Field("op_cast_prev", &Row::avm_alu_op_cast_prev, 1)));

validate_trace(std::move(trace));
}
};

TEST_F(AvmCastTests, basicU8ToU16)
{
trace_builder.op_set(0, 237, 0, AvmMemoryTag::U8);
gen_trace(237, 0, 1, AvmMemoryTag::U8, AvmMemoryTag::U16);
validate_cast_trace(237, 237, 0, 1, AvmMemoryTag::U8, AvmMemoryTag::U16);
}

TEST_F(AvmCastTests, truncationU32ToU8)
{
gen_trace(876123, 0, 1, AvmMemoryTag::U32, AvmMemoryTag::U8);
validate_cast_trace(876123, 91, 0, 1, AvmMemoryTag::U32, AvmMemoryTag::U8);
}

TEST_F(AvmCastTests, sameAddressU16ToU8)
{
gen_trace(1049, 23, 23, AvmMemoryTag::U16, AvmMemoryTag::U8); // M[23] = 1049
validate_cast_trace(1049, 25, 23, 23, AvmMemoryTag::U16, AvmMemoryTag::U8);
}

TEST_F(AvmCastTests, basicU64ToFF)
{
gen_trace(987234987324233324UL, 0, 1, AvmMemoryTag::U64, AvmMemoryTag::FF);
validate_cast_trace(987234987324233324UL, 987234987324233324UL, 0, 1, AvmMemoryTag::U64, AvmMemoryTag::FF);
}

TEST_F(AvmCastTests, sameTagU128)
{
uint128_t a = 312;
a = a << 99;
gen_trace(a, 0, 1, AvmMemoryTag::U128, AvmMemoryTag::U128);
validate_cast_trace(
uint256_t::from_uint128(a), FF(uint256_t::from_uint128(a)), 0, 1, AvmMemoryTag::U128, AvmMemoryTag::U128);
}

TEST_F(AvmCastTests, noTruncationFFToU32)
{
gen_trace(UINT32_MAX, 4, 9, AvmMemoryTag::FF, AvmMemoryTag::U32);
validate_cast_trace(UINT32_MAX, UINT32_MAX, 4, 9, AvmMemoryTag::FF, AvmMemoryTag::U32);
}

TEST_F(AvmCastTests, truncationFFToU16ModMinus1)
{
trace_builder.calldata_copy(0, 0, 1, 0, { FF(FF::modulus - 1) });
trace_builder.op_cast(0, 0, 1, AvmMemoryTag::U16);
trace_builder.return_op(0, 0, 0);
trace = trace_builder.finalize();

validate_cast_trace(FF::modulus - 1, 0, 0, 1, AvmMemoryTag::FF, AvmMemoryTag::U16);
}

TEST_F(AvmCastTests, truncationFFToU16ModMinus2)
{
trace_builder.calldata_copy(0, 0, 1, 0, { FF(FF::modulus_minus_two) });
trace_builder.op_cast(0, 0, 1, AvmMemoryTag::U16);
trace_builder.return_op(0, 0, 0);
auto trace = trace_builder.finalize();
trace = trace_builder.finalize();

validate_cast_trace(FF::modulus_minus_two, UINT16_MAX, 0, 1, AvmMemoryTag::FF, AvmMemoryTag::U16);
}

TEST_F(AvmCastTests, truncationU32ToU16)
{
// 998877665 = OX3B89A9E1
// Truncated to 16 bits: 0XA9E1 = 43489
gen_trace(998877665UL, 0, 1, AvmMemoryTag::U32, AvmMemoryTag::U16);
validate_cast_trace(998877665UL, 43489, 0, 1, AvmMemoryTag::U32, AvmMemoryTag::U16);
}

TEST_F(AvmCastTests, indirectAddrTruncationU64ToU8)
{
// Indirect addresses. src:0 dst:1
// Direct addresses. src:10 dst:11
// Source value: 256'000'000'203 --> truncated to 203
trace_builder.op_set(0, 10, 0, AvmMemoryTag::U32);
trace_builder.op_set(0, 11, 1, AvmMemoryTag::U32);
trace_builder.op_set(0, 256'000'000'203UL, 10, AvmMemoryTag::U64);
trace_builder.op_cast(3, 0, 1, AvmMemoryTag::U8);
trace_builder.return_op(0, 0, 0);
trace = trace_builder.finalize();

validate_cast_trace(256'000'000'203UL, 203, 10, 11, AvmMemoryTag::U64, AvmMemoryTag::U8);
}

TEST_F(AvmCastTests, indirectAddrWrongResolutionU64ToU8)
{
// Indirect addresses. src:5 dst:6
// Direct addresses. src:10 dst:11
trace_builder.op_set(0, 10, 5, AvmMemoryTag::U8); // Not an address type
trace_builder.op_set(0, 11, 6, AvmMemoryTag::U32);
trace_builder.op_set(0, 4234, 10, AvmMemoryTag::U64);
trace_builder.op_cast(3, 5, 6, AvmMemoryTag::U8);
trace_builder.return_op(0, 0, 0);
trace = trace_builder.finalize();

auto row = std::ranges::find_if(trace.begin(), trace.end(), [](Row r) { return r.avm_main_sel_op_cast == FF(1); });
ASSERT_TRUE(row != trace.end());

EXPECT_THAT(*row,
AllOf(Field("sel_op_cast", &Row::avm_main_sel_op_cast, 1),
Field("r_in_tag", &Row::avm_main_r_in_tag, static_cast<uint32_t>(AvmMemoryTag::U64)),
Field("w_in_tag", &Row::avm_main_w_in_tag, static_cast<uint32_t>(AvmMemoryTag::U8)),
Field("alu_in_tag", &Row::avm_main_alu_in_tag, static_cast<uint32_t>(AvmMemoryTag::U8)),
Field("op_a", &Row::avm_main_mem_op_a, 1),
Field("op_c", &Row::avm_main_mem_op_c, 1),
Field("ind_op_a", &Row::avm_main_ind_op_a, 1),
Field("ind_op_c", &Row::avm_main_ind_op_c, 1),
Field("ind_a", &Row::avm_main_ind_a, 5),
Field("ind_c", &Row::avm_main_ind_c, 6),
Field("rwa", &Row::avm_main_rwa, 0),
Field("rwc", &Row::avm_main_rwc, 1),
Field("alu_sel", &Row::avm_main_alu_sel, 0), // ALU trace not activated
Field("tag_err", &Row::avm_main_tag_err, 1))); // Error activated

validate_trace_check_circuit(std::move(trace));
validate_trace(std::move(trace));
}

} // namespace tests_avm

0 comments on commit f0e34bb

Please sign in to comment.