final cleanup

AztecProtocol · Mar 20, 2024 · f79aaff · f79aaff
1 parent a0955a4
commit f79aaff
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/l1-contracts/test/decoders/Decoders.t.sol b/l1-contracts/test/decoders/Decoders.t.sol
@@ -36,9 +36,9 @@ contract DecodersTest is DecoderBase {
 
   function testDecodeBlocks() public {
     _testDecodeBlock("mixed_block_0");
-    // _testDecodeBlock("mixed_block_1");
-    // _testDecodeBlock("empty_block_0");
-    // _testDecodeBlock("empty_block_1");
+    _testDecodeBlock("mixed_block_1");
+    _testDecodeBlock("empty_block_0");
+    _testDecodeBlock("empty_block_1");
   }
 
   function _testDecodeBlock(string memory name) public virtual {

diff --git a/yarn-project/end-to-end/src/integration_l1_publisher.test.ts b/yarn-project/end-to-end/src/integration_l1_publisher.test.ts
@@ -184,10 +184,6 @@ describe('L1Publisher integration', () => {
     processedTx.data.end.encryptedLogsHash = to2Fields(processedTx.encryptedLogs.hash());
     processedTx.data.end.unencryptedLogsHash = to2Fields(processedTx.unencryptedLogs.hash());
 
-    // expect(
-    //   arrayNonEmptyLength(processedTx.data.combinedData.newNullifiers, SideEffectLinkedToNoteHash.isEmpty),
-    // ).toEqual(MAX_NEW_NULLIFIERS_PER_TX);
-
     return processedTx;
   };
 

diff --git a/yarn-project/sequencer-client/src/sequencer/abstract_phase_manager.ts b/yarn-project/sequencer-client/src/sequencer/abstract_phase_manager.ts
@@ -386,6 +386,7 @@ export abstract class AbstractPhaseManager {
       unencryptedLogsHash,
       unencryptedLogPreimagesLength,
       historicalHeader: this.historicalHeader,
+      // TODO(@just-mitch): need better mapping from simulator to revert code.
       reverted: result.reverted ? RevertCode.REVERTED : RevertCode.OK,
     });
   }