Skip to content

Commit

Permalink
comment cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
ledwards2225 committed Apr 18, 2024
1 parent 8db24ee commit fbd8f7e
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ template <typename FF_> class AuxiliaryRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ template <typename FF_> class DeltaRangeConstraintRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ template <typename FF_> class EllipticRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ template <typename FF_> class LookupRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip([[maybe_unused]] const AllEntities& in)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ template <typename FF_> class UltraPermutationRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand All @@ -27,7 +27,6 @@ template <typename FF_> class UltraPermutationRelationImpl {
// non-trivial copy constraints.
return (in.z_perm.value_at(0) == in.z_perm_shift.value_at(0) &&
in.z_perm.value_at(1) == in.z_perm_shift.value_at(1));
// return true;
}

inline static auto& get_grand_product_polynomial(auto& in) { return in.z_perm; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ template <typename FF_> class Poseidon2ExternalRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ template <typename FF_> class Poseidon2InternalRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ consteval std::array<size_t, NUM_SUBRELATIONS> compute_composed_subrelation_part

/**
* @brief Check if the relation has a static skip method to determine if accumulation of its result can be
* optimised based on a single check
* optimised away based on a single check
*
* @details The skip function should return true if relation can be skipped and false if it can't
* @tparam Relation The relation type
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ template <typename FF_> class UltraArithmeticRelationImpl {
};

/**
* @brief Returns true if the contribution from all subrelation for the provided inputs is identically zero
* @brief Returns true if the contribution from all subrelations for the provided inputs is identically zero
*
*/
template <typename AllEntities> inline static bool skip(const AllEntities& in)
Expand Down

0 comments on commit fbd8f7e

Please sign in to comment.