chore: address comments

AztecProtocol · Apr 24, 2024 · fd64638 · fd64638
1 parent dc5614c
commit fd64638
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/yarn-project/builder/src/contract-interface-gen/typescript.ts b/yarn-project/builder/src/contract-interface-gen/typescript.ts
@@ -232,7 +232,6 @@ function generateNotesGetter(input: ContractArtifact) {
     .join(',\n');
 
   return `public static get notes(): ContractNotes<${notesUnionType}> {
-    const notes = this.artifact.outputs.globals.notes ? (this.artifact.outputs.globals.notes as any) : [];
     return {
       ${noteMetadata}
     } as ContractNotes<${notesUnionType}>;

diff --git a/yarn-project/foundation/src/abi/abi.ts b/yarn-project/foundation/src/abi/abi.ts
@@ -277,7 +277,7 @@ export type ContractNote = {
    */
   id: Fr;
   /**
-   * Type of the note
+   * Type of the note (e.g., 'TransparentNote')
    */
   typ: string;
 };
@@ -291,7 +291,7 @@ export type FieldLayout = {
    */
   slot: Fr;
   /**
-   * Type being stored at the slot
+   * Type being stored at the slot (e.g., 'Map<AztecAddress, PublicMutable<U128>>')
    */
   typ: string;
 };

diff --git a/yarn-project/simulator/src/client/private_execution.test.ts b/yarn-project/simulator/src/client/private_execution.test.ts
@@ -732,7 +732,7 @@ describe('Private Execution test suite', () => {
       const secret = new Fr(1n);
       const secretHash = computeSecretHash(secret);
       const note = new Note([secretHash]);
-      // @todo @LHerskind Need to investigate why this was working with `new Fr(5)` as the `example_set = 2` should have caused a failure.
+      // @todo @LHerskind (#6001) Need to investigate why this was working with `new Fr(5)` as the `example_set = 2` should have caused a failure.
       const storageSlot = TestContractArtifact.storageLayout['example_set'].slot;
       oracle.getNotes.mockResolvedValue([
         {