Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to deploy contracts using aztec.js #1608

Closed
Tracked by #1456
benesjan opened this issue Aug 17, 2023 · 1 comment · Fixed by #1703
Closed
Tracked by #1456

Document how to deploy contracts using aztec.js #1608

benesjan opened this issue Aug 17, 2023 · 1 comment · Fixed by #1703
Assignees

Comments

@benesjan
Copy link
Contributor

I've already documented how to deploy contracts using aztec-cli in this PR. Document how to do the same thing using aztec.js. Use the tab functionality of docusaurus to achieve this look:

image

Note: Don't miss the Syncing tab choices section.

spalladino added a commit that referenced this issue Aug 17, 2023
Fixes #1591 

**Note**: I've decided to create a [separate issue
](#1608
documenting how to deploy the contracts using `aztec.js`. I've linked it
to the big docs issue.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
AztecBot pushed a commit to AztecProtocol/docs that referenced this issue Aug 17, 2023
Fixes #1591 

**Note**: I've decided to create a [separate issue
](AztecProtocol/aztec-packages#1608
documenting how to deploy the contracts using `aztec.js`. I've linked it
to the big docs issue.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
@rahul-kothari rahul-kothari self-assigned this Aug 21, 2023
@rahul-kothari
Copy link
Contributor

Gonna pick this up!

rahul-kothari added a commit that referenced this issue Aug 22, 2023
)

Fix #1608

---------

Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
codygunton pushed a commit that referenced this issue Jan 23, 2024
…rmula (#1608)

* Fixed bigfield bugs:
1) The basic CRT formula bug (quick and dirty fix) didn't allow for small values on division (a*b < r)
2) Limb product maximum value computation used uint256_t resulting in overflows
3) Joined range checks can't handle the maximum range values, so in those cases we need to use separate range checks
4) Lots of issues with constant bigfield elements, where we try to access non-existing context
5) assert_is_in_field borrowing logic was wrong
6) 1 miscellaneous funny bug, where evaluate_square_add always expected an even number of elements to add, and because of that did a buffer overread

* Minor fixes

* Fixed Guido's bigfield conditional negate bug and added limb << operator

* Fixed some ASSERTs that triggered Guido's fuzzer.

* Removed misguided ASSERT.

* Fixing picking wrong modulus for counting carry range

* Removed formula dirty fix and test

* Deleted old comments

* Minor typos are fixed

Co-authored-by: arijitdutta67 <arijit.dutta67@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants