Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test to replicate: public kernel outputs wrong final state for insertion into public data tree #1617

Closed
Tracked by #1601
dbanks12 opened this issue Aug 17, 2023 · 1 comment · Fixed by #1685
Closed
Tracked by #1601

Test to replicate: public kernel outputs wrong final state for insertion into public data tree #1617

dbanks12 opened this issue Aug 17, 2023 · 1 comment · Fixed by #1685
Assignees
@dbanks12
Labels
T-bug Type: Bug. Something is broken. T-testing Type: Testing. More tests need to be added.
Milestone
🚀 Initial F&F San...

Comments

@dbanks12
Copy link
Contributor

May only be possible to replicate if we comment out state-update constraints as a way of working around bug replicated in #1616
@dbanks12 dbanks12 added T-bug Type: Bug. Something is broken. T-testing Type: Testing. More tests need to be added. labels Aug 17, 2023
This was referenced Aug 17, 2023
Closed
Closed
Closed
@dbanks12 dbanks12 self-assigned this Aug 18, 2023
@dbanks12 dbanks12 mentioned this issue Aug 21, 2023
Merged
@dbanks12
Copy link
Contributor Author

Will be closed by #1685

suyash67 pushed a commit that referenced this issue Aug 21, 2023
@dbanks12
hack(ordering): public state action ordering (#1685)
4f02d09 
Resolves #1617
Resolves #1622 
Resolves #1623 

Patches the `PublicDataReads` and `PublicDataUpdateRequests` coming from
the public kernel to reorder them properly until public state is
properly reordered (#757).

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
T-bug Type: Bug. Something is broken. T-testing Type: Testing. More tests need to be added.
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

hack(ordering): public state action ordering AztecProtocol/aztec-packages
1 participant
@dbanks12