Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate byte files for l1 contract test #1736

Closed
LHerskind opened this issue Aug 22, 2023 · 0 comments · Fixed by #3923
Closed

feat: generate byte files for l1 contract test #1736

LHerskind opened this issue Aug 22, 2023 · 0 comments · Fixed by #3923
Assignees
@LHerskind
Labels
T-fix Type: fix this. Not quite a bug.

Comments

@LHerskind
Copy link
Contributor

As seen from #1554 changing the value of constants lead to breaking L1 contract tests that depend on encoded blocks.

To fix the issue, create a small script for generating files that can be read in the tests to see that values match. Practically similar to one of the integration test but should also be useful for when changes to the decoder is required.
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 22, 2023
@LHerskind LHerskind mentioned this issue Aug 22, 2023
Merged
4 tasks
@iAmMichaelConnor iAmMichaelConnor added the T-fix Type: fix this. Not quite a bug. label Aug 25, 2023
@LHerskind LHerskind self-assigned this Nov 6, 2023
@LHerskind LHerskind mentioned this issue Jan 10, 2024
Merged
4 tasks
@LHerskind LHerskind moved this from Todo to In Progress in A3 Jan 10, 2024
LHerskind added a commit that referenced this issue Jan 11, 2024
@LHerskind
feat: Generate json blocks for tests (#3923)
a09fd2a 
Fixes #1736 and makes it easier to update the decoders to align with typescript in the future.
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Jan 11, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@LHerskind
feat: Generate json blocks for tests (AztecProtocol#3923)
4aea953 
Fixes AztecProtocol#1736 and makes it easier to update the decoders to align with typescript in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
T-fix Type: fix this. Not quite a bug.
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Generate json blocks for tests AztecProtocol/aztec-packages
2 participants
@LHerskind @iAmMichaelConnor