Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the max circuit size for nodeJS back to 2^19 #1829

Closed
kevaundray opened this issue Aug 26, 2023 · 0 comments · Fixed by #1834
Closed

Change the max circuit size for nodeJS back to 2^19 #1829

kevaundray opened this issue Aug 26, 2023 · 0 comments · Fixed by #1834
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

Problem

Since the NodeJs Cli uses WASM under the hood, it is subject to memory constraints similar to browser.

Solution

The memory constraint caps the circuit size for ultraplonk at 2^19. Change it back to 2^19 and document the discrepancy between the NodeJS cli and the native bb binary.
@kevaundray kevaundray added the C-bb.js Component: bb.js - wrapping bberg in js label Aug 26, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 26, 2023
@kevaundray kevaundray mentioned this issue Aug 26, 2023
Merged
4 tasks
kobyhallx pushed a commit that referenced this issue Aug 28, 2023
@kevaundray
chore: use 2^19 as MAX_CIRCUIT_SIZE for NodeJS CLI (#1834)
c573282 
resolves #1829 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use 2^19 as MAX_CIRCUIT_SIZE for NodeJS CLI AztecProtocol/aztec-packages
1 participant
@kevaundray