Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's move storage declarations into the main.nr file, for similarity to Solidity. #1877

Closed
iAmMichaelConnor opened this issue Aug 30, 2023 · 1 comment · Fixed by #2068
Closed

Let's move storage declarations into the main.nr file, for similarity to Solidity. #1877

iAmMichaelConnor opened this issue Aug 30, 2023 · 1 comment · Fixed by #2068
Assignees
@LeilaWang
Labels
C-aztec.nr Component: Aztec smart contract framework

Comments

@iAmMichaelConnor
Copy link
Contributor

Currently, there's a storage.nr file where storage variables are declared. Let's move this to main.nr to make it easier to follow the code.
@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Aug 30, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Aug 30, 2023
@iAmMichaelConnor iAmMichaelConnor mentioned this issue Aug 30, 2023
Merged
@iAmMichaelConnor
Copy link
Contributor Author

Note, the docs will need to be updated. I recall there's a section that mentions a "convention" to declare storage in a storage.nr file (which will no-longer be the convention).

@LeilaWang LeilaWang self-assigned this Sep 4, 2023
@LeilaWang LeilaWang mentioned this issue Sep 6, 2023
Merged
4 tasks
LeilaWang added a commit that referenced this issue Sep 7, 2023
@LeilaWang
refactor: move storage into main.nr. (#2068)
2c2d72b 
Closes #1877 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeilaWang LeilaWang

Labels
C-aztec.nr Component: Aztec smart contract framework
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move storage into main.nr. AztecProtocol/aztec-packages
2 participants
@LeilaWang @iAmMichaelConnor