Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max circuit size is too large in bb binary #1941

Closed
kevaundray opened this issue Sep 2, 2023 · 0 comments · Fixed by #1942
Closed

Max circuit size is too large in bb binary #1941

kevaundray opened this issue Sep 2, 2023 · 0 comments · Fixed by #1942
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@kevaundray
Copy link
Contributor

## Problem

Spotted by Charlie; the max circuit size constant is too large because transcript00.dat only holds about 5 millions points.

## Solution

Reduce the constant from 2^23 to 2^22
@kevaundray kevaundray added the C-bb.js Component: bb.js - wrapping bberg in js label Sep 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 2, 2023
@kevaundray kevaundray changed the title Max circuit size is too large Max circuit size is too large in bb binary Sep 2, 2023
@kevaundray kevaundray mentioned this issue Sep 2, 2023
Merged
4 tasks
kevaundray added a commit that referenced this issue Sep 2, 2023
@kevaundray
chore: reduce max circuit size in bb binary (#1942)
c61439b 
resolves #1941 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: reduce max circuit size in bb binary AztecProtocol/aztec-packages
1 participant
@kevaundray