Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Base Rollup - migrate cbind routines to msgpack #2096

Closed
Tracked by #738
jeanmon opened this issue Sep 7, 2023 · 2 comments · Fixed by #2263
Closed
Tracked by #738

refactor: Base Rollup - migrate cbind routines to msgpack #2096

jeanmon opened this issue Sep 7, 2023 · 2 comments · Fixed by #2263
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Sep 7, 2023 •
edited
Loading

Tasks
Beta Give feedback
No tasks being tracked yet.
@jeanmon jeanmon mentioned this issue Sep 7, 2023
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 7, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Sep 7, 2023
@jeanmon jeanmon self-assigned this Sep 7, 2023
@iAmMichaelConnor iAmMichaelConnor added the T-refactor Type: this code needs refactoring label Sep 7, 2023
@jeanmon jeanmon added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Sep 8, 2023
@jeanmon jeanmon changed the title refactor: Base Rollup - migrate cbind routines to mspack refactor: Base Rollup - migrate cbind routines to msgpack Sep 12, 2023
@jeanmon
Copy link
Contributor Author

jeanmon commented Sep 12, 2023 •
edited
Loading

Currently blocked by a memory type of issue while running yarn remake-bindings. (See branch jm/2096-base-rollup-cbind-msgpack)

@jeanmon jeanmon mentioned this issue Sep 13, 2023
Merged
4 tasks
@jeanmon
Copy link
Contributor Author

jeanmon commented Sep 13, 2023

Currently blocked by a memory type of issue while running yarn remake-bindings. (See branch jm/2096-base-rollup-cbind-msgpack)

Solved by @ludamad

jeanmon added a commit that referenced this issue Sep 14, 2023
@jeanmon @ludamad
chore(circuits): Base rollup cbind msgpack (#2263)
0d4c707 
Resolves #2096 


# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: ludamad <adam.domurad@gmail.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(circuits): Base rollup cbind msgpack AztecProtocol/aztec-packages
2 participants
@iAmMichaelConnor @jeanmon