Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Merge Rollup - migrate cbind routines to mspack #2116

Closed
Tracked by #738
jeanmon opened this issue Sep 8, 2023 · 0 comments · Fixed by #2192
Closed
Tracked by #738

refactor: Merge Rollup - migrate cbind routines to mspack #2116

jeanmon opened this issue Sep 8, 2023 · 0 comments · Fixed by #2192
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Sep 8, 2023

No description provided.

@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 8, 2023
@jeanmon jeanmon mentioned this issue Sep 8, 2023
Closed
@jeanmon jeanmon self-assigned this Sep 8, 2023
@jeanmon jeanmon added T-refactor Type: this code needs refactoring C-protocol-circuits Component: Protocol circuits (kernel & rollup) labels Sep 8, 2023
@jeanmon jeanmon mentioned this issue Sep 8, 2023
Closed
4 tasks
@jeanmon jeanmon moved this from Todo to In Progress in A3 Sep 11, 2023
@jeanmon jeanmon mentioned this issue Sep 11, 2023
Merged
4 tasks
jeanmon added a commit that referenced this issue Sep 12, 2023
@jeanmon
chore(circuits): merge and root rollup cbind msgpack (#2192)
4f3ecee 
Overview of changes
---------------------

- Use CBIND macro for merge_rollup__sim and root_rollup__sim
- Data structure of the inputs/outputs of these function need to be
reconciled between C++ and TS (member names need to match as
circuits.gen.ts will require reference to TS data structure generated
from the C++ counterparts. In addition, migration from array to TS tuple
is required.)
- Activate new code path in the upper layer (remove wrapper functions in
rollup_wasm_wrapper and directly use mergeRollupSim and rootRollupSim
from circuits.gen.ts).


Resolves #2116
Resolves #2117


# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@jeanmon