Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthWit standard improvements #2199

Closed
9 tasks done
LHerskind opened this issue Sep 11, 2023 · 2 comments
Closed
9 tasks done

AuthWit standard improvements #2199

LHerskind opened this issue Sep 11, 2023 · 2 comments
Labels
T-tracking Type: Tracking Issue. This contains tasklists.

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 11, 2023 •
edited
Loading

Currently the usage of AuthWit is non-standard and somewhat unspecific towards messages. To make sure that it don't run into cross-chain replay attacks or replays between contracts etc, I think it would be prudent to expand it with similar ideas to those of eip712

Tasks
Beta Give feedback
  1. Separate generator for authwit #2676
    LHerskind
  2. Make the auth witness flow on aztec-nr less clunky #2448
    LHerskind
  3. Expose selector from context #2627
    LHerskind
  4. docs: Produce documentation for AuthWit #2710
  5. Allow cancelling a shared authwit token #3007
    S-needs-discussion T-feedback
    LHerskind
  6. feat(AuthWit): API for signing structured message #5075
    LHerskind
  7. refactor(AuthWit): Collapse creating AuthWit syntax on AztecJS #4821
    LHerskind
  8. feat(AuthWit): Query if Authwit was valid in Aztec.nr #4822
    LHerskind
  9. feat!(AuthWit): Domain separator as part of AuthWit message #5074
    LHerskind
@LHerskind LHerskind added the T-tracking Type: Tracking Issue. This contains tasklists. label Sep 11, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 11, 2023
@LHerskind LHerskind mentioned this issue Sep 11, 2023
Merged
4 tasks
@Maddiaa0 Maddiaa0 changed the title AuthWit standard improvements [TRACKING]: AuthWit standard improvements Sep 11, 2023
Maddiaa0 pushed a commit that referenced this issue Sep 13, 2023
@LHerskind
feat: Token standard (#2069)
5e8fbf2 
Fixes #1743.

See #2199 for extensions that is required with generators etc to not
collide with payloads.
@LHerskind LHerskind self-assigned this Sep 25, 2023
@LHerskind LHerskind mentioned this issue Oct 2, 2023
Merged
@LHerskind LHerskind removed their assignment Feb 28, 2024
@LHerskind LHerskind added this to the Developer Facing Aztec.nr milestone Mar 8, 2024
@LHerskind LHerskind changed the title [TRACKING]: AuthWit standard improvements AuthWit standard improvements Mar 9, 2024
@LHerskind
Copy link
Contributor Author

Addressing the missing authentication witness issues is overall a low priority as it is mainly an improvement to developer experience which can be tackled before mainnet, but does not need to be fixed before a testnet.

@LHerskind
Copy link
Contributor Author

Moved #3745 to #5759 and closing down this issue for now.

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-tracking Type: Tracking Issue. This contains tasklists.
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LHerskind