Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to 'wait' in aztec-cli (default to true) #2359

Closed
PhilWindle opened this issue Sep 18, 2023 · 1 comment
Closed

Add option to 'wait' in aztec-cli (default to true) #2359

PhilWindle opened this issue Sep 18, 2023 · 1 comment
Assignees

Comments

@PhilWindle
Copy link
Collaborator

No description provided.

@alexghr alexghr self-assigned this Sep 18, 2023
PhilWindle pushed a commit that referenced this issue Sep 25, 2023
This PR solves issue #2359.

It adds a new `--wait` flag (default `true`) to control whether the cli
waits for transactions to be mined. It also adds the equivalent
`--no-wait` flag to disable this behaviour and have the cli return early
with the transaction hash. These flags do not have short-hand variants.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@alexghr
Copy link
Contributor

alexghr commented Sep 26, 2023

Fixed in #2378

@alexghr alexghr closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants