Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pedersen refactor: remove endomorphism coefficient from ecc add gate #2608

Closed
zac-williamson opened this issue Oct 1, 2023 · 0 comments · Fixed by #3115
Closed

Pedersen refactor: remove endomorphism coefficient from ecc add gate #2608

zac-williamson opened this issue Oct 1, 2023 · 0 comments · Fixed by #3115
Assignees
@zac-williamson
Labels
crypto cryptography

Comments

@zac-williamson
Copy link
Contributor

We don't use the enodmorphism coefficient in the new pedersen gates. We can remove it and simplify the gate relation + simplify ecc_add_gate interface
@zac-williamson zac-williamson added the crypto cryptography label Oct 1, 2023
@zac-williamson zac-williamson self-assigned this Oct 1, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 1, 2023
@kevaundray kevaundray mentioned this issue Oct 28, 2023
Merged
4 tasks
kevaundray added a commit that referenced this issue Oct 30, 2023
@kevaundray
chore: Remove endomorphism coefficient from ecc_add_gate (#3115)
d294987 
Resolves #2608 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zac-williamson zac-williamson

Labels
crypto cryptography
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove endomorphism coefficient from ecc_add_gate AztecProtocol/aztec-packages
1 participant
@zac-williamson