Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up tx object of unneeded fields #3417

Closed
Tracked by #4999
spalladino opened this issue Nov 24, 2023 · 0 comments · Fixed by #5828
Closed
Tracked by #4999

Clean up tx object of unneeded fields #3417

spalladino opened this issue Nov 24, 2023 · 0 comments · Fixed by #5828
Labels
A-protocol Area: relates to designing / explaining the protocol

Comments

@spalladino
Copy link
Collaborator

See TODOs in the codebase.
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 24, 2023
spalladino added a commit that referenced this issue Nov 24, 2023
@spalladino
Add TODOs for issue #3417
1f3a96e
@spalladino spalladino mentioned this issue Nov 24, 2023
Merged
spalladino added a commit that referenced this issue Nov 24, 2023
@spalladino
Add TODOs for issue #3417
52f31bf
spalladino added a commit that referenced this issue Nov 29, 2023
@spalladino
Add TODOs for issue #3417
6150b4d
spalladino added a commit that referenced this issue Nov 29, 2023
@spalladino
docs: Add transaction section to yellow paper (#3418)
44bf30b 
Fixes #3089 

Adds TODOs for #3417
@spalladino spalladino added the A-protocol Area: relates to designing / explaining the protocol label Jan 8, 2024
@alexghr alexghr mentioned this issue Mar 11, 2024
Closed
@alexghr alexghr linked a pull request Apr 18, 2024 that will close this issue
refactor: Reorganize gas fields in structs #5828
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Apr 19, 2024
@Thunkar Thunkar mentioned this issue May 22, 2024
Merged
Thunkar added a commit that referenced this issue May 23, 2024
@Thunkar
feat: batch simulate (#6599)
8d54ac1 
Closes: #6549

Also removes `FunctionData` from `TxExecutionRequest` and a bunch of
other places, in favor of just the `FunctionSelector`(which is actually
what's needed). This was missed from #3417 and was driving me crazy when
trying to add a few more things to `FunctionCall`. It had also leaked
somehow into the AVM enqueued calls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-protocol Area: relates to designing / explaining the protocol
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Reorganize gas fields in structs AztecProtocol/aztec-packages
1 participant
@spalladino