Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-vm: error handling zero division for field memory type #3548

Closed
Tracked by #3310
jeanmon opened this issue Dec 4, 2023 · 0 comments
Closed
Tracked by #3310

public-vm: error handling zero division for field memory type #3548

jeanmon opened this issue Dec 4, 2023 · 0 comments
Assignees
@jeanmon
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Dec 4, 2023

No description provided.

@jeanmon jeanmon mentioned this issue Dec 4, 2023
Closed
@jeanmon jeanmon self-assigned this Dec 4, 2023
@jeanmon jeanmon added the C-avm Component: AVM related tickets (aka public VM) label Dec 4, 2023
@jeanmon jeanmon added this to A3 Dec 4, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 4, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Dec 6, 2023
@jeanmon jeanmon mentioned this issue Dec 7, 2023
Merged
jeanmon added a commit that referenced this issue Dec 8, 2023
@jeanmon
feat(avm-mini): add sub, mul, div and error handling for finite fields (
b190ae9 
#3612)

Resolves #3546 
Resolves #3548

### Description

This PR introduces the following opcodes for the finite field type:

- SUB: subtraction
- MUL: multiplication
- DIV: division

For division, error is raised whenever the numerator is zero. A boolean
column op_err was introduced for this purpose.
@jeanmon jeanmon moved this from In Progress to Done in A3 Dec 8, 2023
@jeanmon jeanmon closed this as completed Dec 11, 2023
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@jeanmon
feat(avm-mini): add sub, mul, div and error handling for finite fields (
a2a5f4d 
AztecProtocol#3612)

Resolves AztecProtocol#3546 
Resolves AztecProtocol#3548

### Description

This PR introduces the following opcodes for the finite field type:

- SUB: subtraction
- MUL: multiplication
- DIV: division

For division, error is raised whenever the numerator is zero. A boolean
column op_err was introduced for this purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeanmon