-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GlobalVariables #3824
Milestone
Comments
Closed
benesjan
added a commit
that referenced
this issue
Feb 7, 2024
rahul-kothari
pushed a commit
that referenced
this issue
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (#4420) * Add expression width into acir (#4014) * init storage macro (#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Add bit size to const opcode (#4385) ([4113cfd](4113cfd)) * Add expression width into acir (#4014) ([4113cfd](4113cfd)) * Allow brillig to read arrays directly from memory (#4460) ([4113cfd](4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (#4478) ([4113cfd](4113cfd)) * **avm:** Back in avm context with macro - refactor context (#4438) ([4113cfd](4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **avm:** Support variable size SET opcode ([#4465](#4465)) ([545b334](545b334)) * **aztec-nr:** Initial work for aztec public vm macro (#4400) ([4113cfd](4113cfd)) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) * Canonical instance deployer contract ([#4436](#4436)) ([b4acc8c](b4acc8c)) * Init storage macro (#4200) ([4113cfd](4113cfd)) * Updating global vars with fees ([#4421](#4421)) ([34109eb](34109eb)), closes [#3824](#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](#4474)) ([fabeac8](fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](#4487)) ([e1d3f5a](e1d3f5a)) * **docs:** Update mdx files to md ([#4459](#4459)) ([e67d94b](e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](#4472)) ([0a8905a](0a8905a)) * Parse instance deployed event ([#4482](#4482)) ([62b171a](62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](#4486)) ([2082fed](2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ([4113cfd](4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (#4415) ([4113cfd](4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](#4483)) ([92d0aa4](92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](#4456)) ([83a3136](83a3136)) * Rename bigint_neg into bigint_sub (#4420) ([4113cfd](4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](902bbd4)) * Surpress chained macro warning (#4396) ([4113cfd](4113cfd)) * Sync to noir-lang/noir ([4113cfd](4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](#4467)) ([2c82b62](2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
TomAFrench
pushed a commit
that referenced
this issue
Feb 7, 2024
TomAFrench
pushed a commit
that referenced
this issue
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (#4420) * Add expression width into acir (#4014) * init storage macro (#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Add bit size to const opcode (#4385) ([4113cfd](4113cfd)) * Add expression width into acir (#4014) ([4113cfd](4113cfd)) * Allow brillig to read arrays directly from memory (#4460) ([4113cfd](4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (#4478) ([4113cfd](4113cfd)) * **avm:** Back in avm context with macro - refactor context (#4438) ([4113cfd](4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **avm:** Support variable size SET opcode ([#4465](#4465)) ([545b334](545b334)) * **aztec-nr:** Initial work for aztec public vm macro (#4400) ([4113cfd](4113cfd)) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) * Canonical instance deployer contract ([#4436](#4436)) ([b4acc8c](b4acc8c)) * Init storage macro (#4200) ([4113cfd](4113cfd)) * Updating global vars with fees ([#4421](#4421)) ([34109eb](34109eb)), closes [#3824](#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](#4474)) ([fabeac8](fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](#4487)) ([e1d3f5a](e1d3f5a)) * **docs:** Update mdx files to md ([#4459](#4459)) ([e67d94b](e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](#4472)) ([0a8905a](0a8905a)) * Parse instance deployed event ([#4482](#4482)) ([62b171a](62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](#4486)) ([2082fed](2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (#4221) [skip ci] ([4113cfd](4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (#4415) ([4113cfd](4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](#4483)) ([92d0aa4](92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](#4456)) ([83a3136](83a3136)) * Rename bigint_neg into bigint_sub (#4420) ([4113cfd](4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](902bbd4)) * Surpress chained macro warning (#4396) ([4113cfd](4113cfd)) * Sync to noir-lang/noir ([4113cfd](4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](#4467)) ([2c82b62](2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](#4464)) ([5e16063](5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](#4478)) ([bbfa337](bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](#4441)) ([934fabc](934fabc)), closes [#4304](#4304) * **bb:** Op counting mode ([#4437](#4437)) ([5d00cff](5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
AztecBot
added a commit
to AztecProtocol/barretenberg
that referenced
this issue
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) * Add expression width into acir (AztecProtocol/aztec-packages#4014) * init storage macro (AztecProtocol/aztec-packages#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([#4464](AztecProtocol/aztec-packages#4464)) ([5e16063](AztecProtocol/aztec-packages@5e16063)) * Add bit size to const opcode (AztecProtocol/aztec-packages#4385) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Add expression width into acir (AztecProtocol/aztec-packages#4014) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Allow brillig to read arrays directly from memory (AztecProtocol/aztec-packages#4460) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](AztecProtocol/aztec-packages#4478)) ([bbfa337](AztecProtocol/aztec-packages@bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol/aztec-packages#4478) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol/aztec-packages#4438) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **avm:** Generic bytecode deserialization ([#4441](AztecProtocol/aztec-packages#4441)) ([934fabc](AztecProtocol/aztec-packages@934fabc)), closes [#4304](AztecProtocol/aztec-packages#4304) * **avm:** Support variable size SET opcode ([#4465](AztecProtocol/aztec-packages#4465)) ([545b334](AztecProtocol/aztec-packages@545b334)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol/aztec-packages#4400) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * **bb:** Op counting mode ([#4437](AztecProtocol/aztec-packages#4437)) ([5d00cff](AztecProtocol/aztec-packages@5d00cff)) * Canonical instance deployer contract ([#4436](AztecProtocol/aztec-packages#4436)) ([b4acc8c](AztecProtocol/aztec-packages@b4acc8c)) * Init storage macro (AztecProtocol/aztec-packages#4200) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Updating global vars with fees ([#4421](AztecProtocol/aztec-packages#4421)) ([34109eb](AztecProtocol/aztec-packages@34109eb)), closes [#3824](AztecProtocol/aztec-packages#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([#4474](AztecProtocol/aztec-packages#4474)) ([fabeac8](AztecProtocol/aztec-packages@fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([#4487](AztecProtocol/aztec-packages#4487)) ([e1d3f5a](AztecProtocol/aztec-packages@e1d3f5a)) * **docs:** Update mdx files to md ([#4459](AztecProtocol/aztec-packages#4459)) ([e67d94b](AztecProtocol/aztec-packages@e67d94b)) * **docs:** Update private voting tutorial cli commands ([#4472](AztecProtocol/aztec-packages#4472)) ([0a8905a](AztecProtocol/aztec-packages@0a8905a)) * Parse instance deployed event ([#4482](AztecProtocol/aztec-packages#4482)) ([62b171a](AztecProtocol/aztec-packages@62b171a)) ### Miscellaneous * Able to run noir-sync manually ([#4486](AztecProtocol/aztec-packages#4486)) ([2082fed](AztecProtocol/aztec-packages@2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol/aztec-packages#4221) [skip ci] ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol/aztec-packages#4415) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Lift rollup address check & deplot kv-store to npm ([#4483](AztecProtocol/aztec-packages#4483)) ([92d0aa4](AztecProtocol/aztec-packages@92d0aa4)) * Nuked `OptionallyRevealedData` ([#4456](AztecProtocol/aztec-packages#4456)) ([83a3136](AztecProtocol/aztec-packages@83a3136)) * Rename bigint_neg into bigint_sub (AztecProtocol/aztec-packages#4420) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](AztecProtocol/aztec-packages@902bbd4)) * Surpress chained macro warning (AztecProtocol/aztec-packages#4396) ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Sync to noir-lang/noir ([4113cfd](AztecProtocol/aztec-packages@4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([#4467](AztecProtocol/aztec-packages#4467)) ([2c82b62](AztecProtocol/aztec-packages@2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([#4464](AztecProtocol/aztec-packages#4464)) ([5e16063](AztecProtocol/aztec-packages@5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([#4478](AztecProtocol/aztec-packages#4478)) ([bbfa337](AztecProtocol/aztec-packages@bbfa337)) * **avm:** Generic bytecode deserialization ([#4441](AztecProtocol/aztec-packages#4441)) ([934fabc](AztecProtocol/aztec-packages@934fabc)), closes [#4304](AztecProtocol/aztec-packages#4304) * **bb:** Op counting mode ([#4437](AztecProtocol/aztec-packages#4437)) ([5d00cff](AztecProtocol/aztec-packages@5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this issue
Feb 28, 2024
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this issue
Feb 28, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@aztec-packages-v0.22.0...aztec-packages-v0.23.0) (2024-02-07) ### ⚠ BREAKING CHANGES * rename bigint_neg into bigint_sub (AztecProtocol#4420) * Add expression width into acir (AztecProtocol#4014) * init storage macro (AztecProtocol#4200) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol#4221) [skip ci] ### Features * Add additional error types to verifier contract and revert early ([AztecProtocol#4464](AztecProtocol#4464)) ([5e16063](AztecProtocol@5e16063)) * Add bit size to const opcode (AztecProtocol#4385) ([4113cfd](AztecProtocol@4113cfd)) * Add expression width into acir (AztecProtocol#4014) ([4113cfd](AztecProtocol@4113cfd)) * Allow brillig to read arrays directly from memory (AztecProtocol#4460) ([4113cfd](AztecProtocol@4113cfd)) * Allow nested arrays and vectors in Brillig foreign calls ([AztecProtocol#4478](AztecProtocol#4478)) ([bbfa337](AztecProtocol@bbfa337)) * Allow nested arrays and vectors in Brillig foreign calls (AztecProtocol#4478) ([4113cfd](AztecProtocol@4113cfd)) * **avm:** Back in avm context with macro - refactor context (AztecProtocol#4438) ([4113cfd](AztecProtocol@4113cfd)) * **avm:** Generic bytecode deserialization ([AztecProtocol#4441](AztecProtocol#4441)) ([934fabc](AztecProtocol@934fabc)), closes [AztecProtocol#4304](AztecProtocol#4304) * **avm:** Support variable size SET opcode ([AztecProtocol#4465](AztecProtocol#4465)) ([545b334](AztecProtocol@545b334)) * **aztec-nr:** Initial work for aztec public vm macro (AztecProtocol#4400) ([4113cfd](AztecProtocol@4113cfd)) * **bb:** Op counting mode ([AztecProtocol#4437](AztecProtocol#4437)) ([5d00cff](AztecProtocol@5d00cff)) * Canonical instance deployer contract ([AztecProtocol#4436](AztecProtocol#4436)) ([b4acc8c](AztecProtocol@b4acc8c)) * Init storage macro (AztecProtocol#4200) ([4113cfd](AztecProtocol@4113cfd)) * Updating global vars with fees ([AztecProtocol#4421](AztecProtocol#4421)) ([34109eb](AztecProtocol@34109eb)), closes [AztecProtocol#3824](AztecProtocol#3824) ### Bug Fixes * Delay rming bins till right before installing them. ([AztecProtocol#4474](AztecProtocol#4474)) ([fabeac8](AztecProtocol@fabeac8)) * **docs:** Add redirect for top google hit giving 404 ([AztecProtocol#4487](AztecProtocol#4487)) ([e1d3f5a](AztecProtocol@e1d3f5a)) * **docs:** Update mdx files to md ([AztecProtocol#4459](AztecProtocol#4459)) ([e67d94b](AztecProtocol@e67d94b)) * **docs:** Update private voting tutorial cli commands ([AztecProtocol#4472](AztecProtocol#4472)) ([0a8905a](AztecProtocol@0a8905a)) * Parse instance deployed event ([AztecProtocol#4482](AztecProtocol#4482)) ([62b171a](AztecProtocol@62b171a)) ### Miscellaneous * Able to run noir-sync manually ([AztecProtocol#4486](AztecProtocol#4486)) ([2082fed](AztecProtocol@2082fed)) * **acir:** Move `is_recursive` flag to be part of the circuit definition (AztecProtocol#4221) [skip ci] ([4113cfd](AztecProtocol@4113cfd)) * Add bigint solver in ACVM and add a unit test for bigints in Noir (AztecProtocol#4415) ([4113cfd](AztecProtocol@4113cfd)) * Lift rollup address check & deplot kv-store to npm ([AztecProtocol#4483](AztecProtocol#4483)) ([92d0aa4](AztecProtocol@92d0aa4)) * Nuked `OptionallyRevealedData` ([AztecProtocol#4456](AztecProtocol#4456)) ([83a3136](AztecProtocol@83a3136)) * Rename bigint_neg into bigint_sub (AztecProtocol#4420) ([4113cfd](AztecProtocol@4113cfd)) * Replace relative paths to noir-protocol-circuits ([902bbd4](AztecProtocol@902bbd4)) * Surpress chained macro warning (AztecProtocol#4396) ([4113cfd](AztecProtocol@4113cfd)) * Sync to noir-lang/noir ([4113cfd](AztecProtocol@4113cfd)) * Unhardcode canonical addresses of deployer and registerer contracts ([AztecProtocol#4467](AztecProtocol#4467)) ([2c82b62](AztecProtocol@2c82b62)) </details> <details><summary>barretenberg.js: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg.js-v0.22.0...barretenberg.js-v0.23.0) (2024-02-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.23.0</summary> ## [0.23.0](AztecProtocol/aztec-packages@barretenberg-v0.22.0...barretenberg-v0.23.0) (2024-02-07) ### Features * Add additional error types to verifier contract and revert early ([AztecProtocol#4464](AztecProtocol#4464)) ([5e16063](AztecProtocol@5e16063)) * Allow nested arrays and vectors in Brillig foreign calls ([AztecProtocol#4478](AztecProtocol#4478)) ([bbfa337](AztecProtocol@bbfa337)) * **avm:** Generic bytecode deserialization ([AztecProtocol#4441](AztecProtocol#4441)) ([934fabc](AztecProtocol@934fabc)), closes [AztecProtocol#4304](AztecProtocol#4304) * **bb:** Op counting mode ([AztecProtocol#4437](AztecProtocol#4437)) ([5d00cff](AztecProtocol@5d00cff)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Blocked by #3937.
This have some overlaps with the updating of the header, so it might be useful to do them in series instead of in parallel.
The global variables should be extended with
coinbase
andfee_recipient
such that the proof commits to these values.coinbase
is theEthAddress
that is to receive block rewards on underlying.fee_recipient
is theAztecAddress
that is to receive transaction fees inside the systemThe global variables touches many parts of the code-base, and need additional test in multiple areas. Note, as these extra variables are dependent on knowledge for the current values, they will only be up to date in public execution, but can be accessed historically in private execution.
The below list is likely not pointing out every place where updates are needed, but I tried to extend it as much as possible without just building the thing. Unordered.
Tasks
The text was updated successfully, but these errors were encountered: