Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-vm(simulator): Journal should keep track of reads #3999

Closed
Tracked by #3313
Maddiaa0 opened this issue Jan 12, 2024 · 0 comments · Fixed by #4315
Closed
Tracked by #3313

public-vm(simulator): Journal should keep track of reads #3999

Maddiaa0 opened this issue Jan 12, 2024 · 0 comments · Fixed by #4315
Assignees
@Maddiaa0
Labels
C-avm Component: AVM related tickets (aka public VM)
Milestone
AVM Simulator Pha...

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Jan 12, 2024 •
edited
Loading

Overview

During execution of the vm, the journal needs to keep track of public state reads. This is as they will need to be validated later in time in the storage validation circuit.

Links
@Maddiaa0 Maddiaa0 mentioned this issue Jan 12, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Jan 12, 2024
This was referenced Jan 12, 2024
Closed
Merged
@dbanks12 dbanks12 added the C-avm Component: AVM related tickets (aka public VM) label Jan 16, 2024
@jzaki jzaki mentioned this issue Jan 17, 2024
Closed
@dbanks12 dbanks12 added this to the AVM Simulator (partial) milestone Jan 30, 2024
@dbanks12 dbanks12 changed the title public-vm(ts): Journal should keep track of reads public-vm(simulator): Journal should keep track of reads Jan 30, 2024
@Maddiaa0 Maddiaa0 moved this from Todo to In Progress in A3 Jan 30, 2024
@Maddiaa0 Maddiaa0 mentioned this issue Jan 30, 2024
Merged
@Maddiaa0 Maddiaa0 moved this from In Progress to In Review in A3 Jan 30, 2024
Maddiaa0 added a commit that referenced this issue Jan 31, 2024
@Maddiaa0
feat(avm): keep history of reads and writes in journal (#4315)
cdf1baf 
fixes: #3999
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jan 31, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@Maddiaa0
feat(avm): keep history of reads and writes in journal (AztecProtocol…
dd08af4 
…#4315)

fixes: AztecProtocol#3999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Maddiaa0 Maddiaa0

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Archived in project
Milestone
AVM Simulator Phase 1 (partial)
Development

Successfully merging a pull request may close this issue.

feat(avm): keep history of reads and writes in journal AztecProtocol/aztec-packages
2 participants
@dbanks12 @Maddiaa0