Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[contract-deploy] Broadcast all private and unconstrained functions from ClassRegisterer #4462

Closed
Tracked by #4052
spalladino opened this issue Feb 6, 2024 · 0 comments · Fixed by #5298 or #5296
Closed
Tracked by #4052

[contract-deploy] Broadcast all private and unconstrained functions from ClassRegisterer #4462

spalladino opened this issue Feb 6, 2024 · 0 comments · Fixed by #5298 or #5296
Labels
S-needs-discussion Status: Still needs more discussion before work can start.

Comments

@spalladino
Copy link
Collaborator

spalladino commented Feb 6, 2024 •
edited
Loading

Similar to #4427, but broadcast all functions in the same method, so it doesn't require supplying merkle membership proofs for each.

Consider whether it's worth the effort. We can always just broadcast all functions individually on the same tx (at the cost of a few merkle paths) and be done with it. If we remove this, remove it from the yellow paper as well.
@spalladino spalladino mentioned this issue Feb 6, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 6, 2024
@spalladino spalladino added the S-needs-discussion Status: Still needs more discussion before work can start. label Feb 6, 2024
@spalladino spalladino mentioned this issue Mar 18, 2024
Merged
spalladino added a commit that referenced this issue Mar 18, 2024
@spalladino
docs: Remove broadcast-all methods from class registerer (#5298)
21ccb4b 
We were running into too-large unencrypted logs when trying to broadcast
all functions, and it's easier to just replace this with multiple
invocations to individual broadcasts.

Closes #4462
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 18, 2024
@AztecBot AztecBot mentioned this issue Mar 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-needs-discussion Status: Still needs more discussion before work can start.
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@spalladino