Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update naming of state vars wrappers #4735

Closed
benesjan opened this issue Feb 23, 2024 · 0 comments · Fixed by #4739
Closed

Update naming of state vars wrappers #4735

benesjan opened this issue Feb 23, 2024 · 0 comments · Fixed by #4739
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Feb 23, 2024 •
edited
Loading

We had a discussion at the office and we'll do the following naming changes:

  1. ImmutableSingleton -> PrivateImmutable
  2. Singleton -> PrivateMutable
  3. StablePublicState -> SharedImmutable
  4. SlowUpdates -> SharedMutable
  5. PublicState -> PublicMutable

Note 1: I'll implement PublicImmutable in a separate issue. PublicImmutable will be implementation-wise very similar to PublicMutable but instead of write it has initialize function which checks whether placeholder value at (slot - 1) is 0.
Note 2: SlowUpdates will be renamed to SharedMutable once the implementation is ready (issue).

image
@benesjan benesjan self-assigned this Feb 23, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 23, 2024
@benesjan benesjan mentioned this issue Feb 23, 2024
Merged
@LHerskind LHerskind mentioned this issue Feb 26, 2024
Closed
@benesjan benesjan mentioned this issue Feb 26, 2024
Closed
@LHerskind LHerskind mentioned this issue Feb 26, 2024
Open
benesjan added a commit that referenced this issue Feb 27, 2024
@benesjan
feat!: renamings of state var wrappers (#4739)
4667c27 
1. Fixes #4735
2. SharedImmutable now enforces that the value was not initialized
before by doing a "value at placeholder slot is zero" check.
3. Adds calls to empty `context.is_deployment(...)` and links the
relevant issue in the function.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: renamings of state var wrappers AztecProtocol/aztec-packages
1 participant
@benesjan