Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNENCRYPTEDLOG #4838

Closed
Tracked by #4790
dbanks12 opened this issue Feb 28, 2024 · 0 comments · Fixed by #4926
Closed
Tracked by #4790

UNENCRYPTEDLOG #4838

dbanks12 opened this issue Feb 28, 2024 · 0 comments · Fixed by #4926
Assignees
@fcarreiro

Comments

@dbanks12
Copy link
Contributor

No description provided.

@dbanks12 dbanks12 mentioned this issue Feb 28, 2024
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Feb 28, 2024
@fcarreiro fcarreiro self-assigned this Mar 4, 2024
@fcarreiro fcarreiro mentioned this issue Mar 5, 2024
Merged
fcarreiro added a commit that referenced this issue Mar 5, 2024
@fcarreiro
feat(avm-simulator): implement EMITUNENCRYPTEDLOG (#4926)
5f3304e 
* Implements `EMITUNENCRYPTEDLOG` opcode in the simulator (including `event_selector` which was previously missing)
* Adds `emit_unencrypted_log<T>` to `avm.nr` (the new public context).
  * Observe that this function takes any type `T` that noir is happy to autoconvert to `[Field; N]`
  * Observe that it does NOT take an `address`. Instead the simulator uses `context.environment.address`. See [this thread](https://aztecprotocol.slack.com/archives/C03P17YHVK8/p1709326971482429).
  * This function is tested with fields and raw strings. I think it would also probably work with `CompressedString` and other serializable types, but I can't test it now due to Brillig problems.
* Updated spec.

Closes #4838.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Mar 5, 2024
@fcarreiro fcarreiro mentioned this issue Mar 8, 2024
Merged
fcarreiro added a commit that referenced this issue Mar 11, 2024
@fcarreiro
chore(avm-simulator): enable compressed strings unencrypted log test (#…
8f7519b 
…5083)

Now that Brillig behaves better, we can enable the compressed strings test for unencrypted logs.

Ref: #4838.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcarreiro fcarreiro

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(avm-simulator): implement EMITUNENCRYPTEDLOG AztecProtocol/aztec-packages
2 participants
@fcarreiro @dbanks12